[FLINK-39257] Remove compatibility code for older versions of Flink.#4317
Merged
Conversation
Signed-off-by: Pei Yu <125331682@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes reflection-based compatibility shims for Flink 1.18 in DataSinkTranslator, replacing them with direct calls to TwoPhaseCommittingSink and CommitterOperatorFactory APIs.
Changes:
- Replaced reflection-based
getCommittableSerializerandgetCommitterOperatorFactorymethods with direct API usage - Added explicit import of
CommitterOperatorFactoryand removed unnecessary imports
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yuxiqian
approved these changes
Mar 16, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning up!
1 task
Mrart
pushed a commit
to Mrart/flink-cdc
that referenced
this pull request
Mar 26, 2026
…pache#4317) Signed-off-by: Pei Yu <125331682@qq.com>
ThorneANN
pushed a commit
to ThorneANN/flink-cdc
that referenced
this pull request
Mar 31, 2026
…pache#4317) Signed-off-by: Pei Yu <125331682@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.