[FLINK-39300][mysql-cdc] Reuse ObjectMapper as static constant to avoid repeated instantiation.#4330
Open
eric666666 wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39300][mysql-cdc] Reuse ObjectMapper as static constant to avoid repeated instantiation.#4330eric666666 wants to merge 2 commits intoapache:masterfrom
eric666666 wants to merge 2 commits intoapache:masterfrom
Conversation
…id repeated instantiation.
Author
|
/retest |
Author
|
The test failure TransformE2eITCase#testWildcardWithMetadataColumnTransform is a flaky E2E test caused by waitUntilSpecificEvent timeout in the CI environment. It is unrelated to this PR's changes, which only refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR addresses FLINK-39300.
Jackson's
ObjectMapperis expensive to instantiate (triggers reflection-basedmodule discovery and codec registry initialization), yet it is thread-safe once
configured. Two classes in the MySQL CDC connector were unnecessarily creating
new
ObjectMapperinstances on every method call:BinlogOffsetSerializer: bothserialize()anddeserialize()created new instancesOnlineSchemaChangeUtils: bothisOnLineSchemaChangeEvent()andparseOnLineSchemaRenameEvent()created new instancesThis PR extracts
ObjectMapperinto a sharedprivate static finalconstant ineach class to eliminate repeated instantiation overhead.