[FLINK-39696][runtime] Use source partition for distributed flush events#4400
Merged
Conversation
yuxiqian
approved these changes
May 18, 2026
Member
yuxiqian
left a comment
There was a problem hiding this comment.
LGTM. We may add an E2E case later, after we have a distributed source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes FLINK-39696.
What is the purpose of the change
This PR fixes inconsistent source identity propagation in the distributed schema evolution flow.
In distributed mode,
SchemaOperatorforwards schema change requests to the coordinator with the original upstream source partition viaSchemaChangeRequest(sourcePartition, sinkSubTaskId, schemaChangeEvent).However, when emitting the downstream
FlushEvent, it previously used the currentSchemaOperatorsubtask id instead of the original source partition.As a result, the same schema change could be identified by different ids in different parts of the pipeline:
SchemaChangeRequest/ coordinator deduplication use the original source partitionFlushEvent/ downstream flush handling use theSchemaOperatorsubtask idThis makes the flush lineage inconsistent with the schema-change lineage in distributed topology. In particular, duplicated broadcast branches of the same upstream schema change cannot be consistently aligned
by the original source partition.
Brief change log
schemaChangeRequest.getSourceSubTaskId()instead ofSchemaOperator'ssubTaskIdwhen constructing distributedFlushEventSchemaEvolveTestto verify thatFlushEventkeeps the original source partition even when theSchemaOperatorsubtask id is differentDistributedEventOperatorTestHarnessso tests can inject a custom operator subtask index and reliably reproduce this scenarioVerifying this change
This change is verified by unit tests:
SchemaEvolveTest#testFlushEventUsesSourcePartitionInsteadOfSchemaOperatorSubtaskDoes this pull request potentially affect one of the following parts:
@Public(@PublicEvolving): noDocumentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable