[FLINK-36651][Connectors/Elasticsearch] Fix IT test not compatible with 1.20, drop main branch tests for 1.18 #110
+9
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
reta
reviewed
Nov 3, 2024
...e/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
Outdated
Show resolved
Hide resolved
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
e3524aa to
60daf78
Compare
reta
reviewed
Nov 3, 2024
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
60daf78 to
bfb4631
Compare
reta
approved these changes
Nov 3, 2024
dannycranmer
requested changes
Nov 4, 2024
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
bfb4631 to
4ec8d84
Compare
snuyanzin
reviewed
Nov 4, 2024
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
4ec8d84 to
8b0b019
Compare
snuyanzin
reviewed
Nov 4, 2024
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
8b0b019 to
f826aca
Compare
snuyanzin
approved these changes
Nov 4, 2024
Contributor
|
oops seems something wrong with archunit tests |
…th 1.20, drop main branch tests for 1.18
vahmed-hamdy
force-pushed
the
FLINK-36651-fix-ci
branch
from
f826aca to
60891d0
Compare
vahmed-hamdy
changed the title
Contributor
Author
|
@snuyanzin yeah, I guess we can update the arch rules separately, could you please rereun the CI and check now? |
Contributor
|
@dannycranmer do you see anything else that could be improved here? |
dannycranmer
approved these changes
Nov 15, 2024
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Successful run:
https://github.com/vahmed-hamdy/flink-connector-elasticsearch/actions/runs/11645464636