Skip to content

Conversation

@Milesian111
Copy link
Contributor

There is no method named "ElasticsearchEmitter.static", it should be "ElasticsearchEmitter.static_index".

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@Milesian111 Milesian111 marked this pull request as draft February 18, 2025 06:08
@Milesian111 Milesian111 marked this pull request as ready for review February 18, 2025 06:16
@Milesian111
Copy link
Contributor Author

Milesian111 commented Mar 11, 2025

@schulzp @alpinegizmo @aljoscha @rmetzger @reswqa @mtfelisb @rmetzger Could anyone help review my code? Thank you very much!

Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Milesian111. LGTM!

@reswqa reswqa merged commit c80d39b into apache:main Mar 18, 2025
9 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 18, 2025

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants