Add test proving backoffLimit=-1 (unlimited retries) bug in FlinkStat…#1084
Open
vsantwana wants to merge 2 commits intoapache:mainfrom
Open
Add test proving backoffLimit=-1 (unlimited retries) bug in FlinkStat…#1084vsantwana wants to merge 2 commits intoapache:mainfrom
vsantwana wants to merge 2 commits intoapache:mainfrom
Conversation
…eSnapshot The default backoffLimit of -1 (documented as "unlimited retries") causes snapshots to immediately fail after the first error. The check `failures > backoffLimit` evaluates to `1 > -1` which is always true, so no retries ever happen with the default configuration. This test is expected to fail until the bug is fixed.
d25b9df to
8e18ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eSnapshot
The default backoffLimit of -1 (documented as "unlimited retries") causes snapshots to immediately fail after the first error. The check
failures > backoffLimitevaluates to1 > -1which is always true, so no retries ever happen with the default configuration.This test is expected to fail until the bug is fixed.
What is the purpose of the change
(For example: This pull request adds a new feature to periodically create and maintain savepoints through the
FlinkDeploymentcustom resource.)Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: (yes / no)Documentation