[FLINK-39501] Logback Support in Flink Kubernetes Operator#1096
Open
Dennis-Mircea wants to merge 1 commit intoapache:mainfrom
Open
[FLINK-39501] Logback Support in Flink Kubernetes Operator#1096Dennis-Mircea wants to merge 1 commit intoapache:mainfrom
Dennis-Mircea wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces Logback as an alternative logging framework for the Flink Kubernetes Operator, selectable at install time via the
logging.frameworkHelm value. Previously, only Log4j2 was supported.Brief change log
logback-operator.xmlandlogback-console.xmlconfiguration files with log output format aligned to the existing Log4j2 defaultslogging.frameworkHelm value to switch betweenlog4j2(default) andlogbackat install timedocker-entrypoint.shto place the correct SLF4J binding JAR on the classpath based on the selected framework.propertiesfiles)test_log4j2_logging.sh,test_logback_logging.sh)e2e_loggingjob inci.yml)Verifying this change
This change added tests and can be verified as follows:
test_log4j2_logging.shE2E test that deploys the operator with the default Log4j2 framework and verifies log format (timestamp with,millisecond separator, logger name, log level)test_logback_logging.shE2E test that switches the framework to Logback viavalues.yamland verifies log format (timestamp with.millisecond separator, logger name, log level)helm unittest -f 'tests/**/*_test.yaml' helm/flink-kubernetes-operator(14 suites, 60 tests)--set logging.framework=log4j2and--set logging.framework=logback, confirming correct log output format inkubectl logsDoes this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation