[FLINK-37269][table] Add new DESCRIPTOR type #26144
Open
+1,606
−618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
commented
Feb 11, 2025
|
|
||
| // ----- FLINK MODIFICATION BEGIN ----- | ||
| // COLUMN_LIST is assignable from ... | ||
| rules.add(SqlTypeName.COLUMN_LIST, EnumSet.of(SqlTypeName.COLUMN_LIST)); |
There was a problem hiding this comment.
@snuyanzin could you contribute this line to Calcite? Should be an easy PR if not just a hotfix commit.
snuyanzin
reviewed
Feb 12, 2025
| @@ -252,6 +253,12 @@ | |||
| * <li>Added in FLINK-34312: Lines 5804 ~ 5813 | |||
| * <li>Added in FLINK-34057, FLINK-34058, FLINK-34312: Lines 6263 ~ 6279 | |||
| * </ol> | |||
There was a problem hiding this comment.
I feel like we need to update line numbers here
snuyanzin
reviewed
Feb 12, 2025
| @@ -335,7 +335,7 @@ private DataType extractDataTypeOrError( | |||
| // early and helpful exception for common mistakes | |||
| checkForCommonErrors(type); | |||
|
|
|||
| // PREDEFINED | |||
| // PREDEFINED and DESCRIPTOR | |||
| resultDataType = extractPredefinedType(template, type); | |||
There was a problem hiding this comment.
given the fact that extract method here and for others contains type, should it be also renamed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds the DESCRIPTOR type to the Flink type system. The DESCRIPTOR type is defined by the SQL standard and necessary for passing a list of column names into PTFs. PTFs will esp. use them for time semantics. Built-in window PTFs already partially supported DESCRIPTORs but were tailored to those window uses cases only. This PR generalizes concepts and cleans up the planner.
Calcite has partial support for DESCRIPTOR but had some bugs in the stack that had to be patched in this PR.
Brief change log
DescriptorTypelogical typeDESCRIPTORdata type in function API incl. annotationsVerifying this change
This change added tests and can be verified as follows:
ProcessTableFunctionSemanticTests,ProcessTableFunctionTests,Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation