Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters #26201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Milesian111
Copy link

@Milesian111 Milesian111 commented Feb 24, 2025

[FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters

What is the purpose of the change

This pull request dealt with a "TODO" at class "SqlNodeToOperationConversion", method "convertValidatedSqlNode":
"TODO: all the below conversion logic should be migrated to SqlNodeConverters".
And I migrated over 40 of converters to SqlNodeConverters.

Brief change log

  • The Sql conversion logic codes in SqlNodeToOperationConversion are all migrated to SqlNodeConverters

Verifying this change

This change is already covered by existing tests, such as SqlDdlToOperationConverterTest and SqlDmlToOperationConverterTest .

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 24, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…qlNodeToOperationConversion to SqlNodeConverters
@Milesian111
Copy link
Author

@flinkbot run azure

1 similar comment
@Milesian111
Copy link
Author

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants