-
Notifications
You must be signed in to change notification settings - Fork 458
[build] Upgrade JDK compile version as 11 #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0e078a
Fluss support jdk 11
loserwang1024 f541c72
support java 11 as default compile version.
loserwang1024 ca0cdef
modified based on cr
loserwang1024 da9fd58
Jark's update
wuchong 90de08f
fix java8
wuchong be1fe26
fix matrix
wuchong 002a220
add --add-opens for tests
wuchong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| ################################################################################ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| ################################################################################ | ||
|
|
||
| # .github/workflows/ci-template.yaml | ||
| name: CI Template | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| java-version: | ||
| required: true | ||
| type: string | ||
| maven-parameters: | ||
| description: "Any parameters of the Maven command." | ||
| required: false | ||
| type: string | ||
| default: "" | ||
| jobs: | ||
| build: | ||
| runs-on: self-hosted | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| module: [ core, flink ] | ||
| name: "${{ matrix.module }}" | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: ${{ inputs.java-version }} | ||
| distribution: 'temurin' | ||
| - name: Build | ||
| run: | | ||
| mvn -T 1C -B clean install -DskipTests | ||
| - name: Test | ||
| timeout-minutes: 60 | ||
| run: | | ||
| TEST_MODULES=$(./.github/workflows/stage.sh ${{ matrix.module }}) | ||
| echo "github ref: ${{ github.ref }}" | ||
| echo "Start testing modules: $TEST_MODULES" | ||
| mvn -B verify $TEST_MODULES -Ptest-coverage -Ptest-${{ matrix.module }} -Dlog.dir=${{ runner.temp }}/fluss-logs -Dlog4j.configurationFile=${{ github.workspace }}/tools/ci/log4j.properties ${{ inputs.maven-parameters }} | ||
| env: | ||
| MAVEN_OPTS: -Xmx4096m | ||
| ARTIFACTS_OSS_ENDPOINT: ${{ secrets.ARTIFACTS_OSS_ENDPOINT }} | ||
| ARTIFACTS_OSS_REGION: ${{ secrets.ARTIFACTS_OSS_REGION }} | ||
| ARTIFACTS_OSS_BUCKET: ${{ secrets.ARTIFACTS_OSS_BUCKET }} | ||
| ARTIFACTS_OSS_ACCESS_KEY: ${{ secrets.ARTIFACTS_OSS_ACCESS_KEY }} | ||
| ARTIFACTS_OSS_SECRET_KEY: ${{ secrets.ARTIFACTS_OSS_SECRET_KEY }} | ||
| ARTIFACTS_OSS_STS_ENDPOINT: ${{ secrets.ARTIFACTS_OSS_STS_ENDPOINT }} | ||
| ARTIFACTS_OSS_ROLE_ARN: ${{ secrets.ARTIFACTS_OSS_ROLE_ARN }} | ||
| - name: Upload build logs | ||
| uses: actions/upload-artifact@v4 | ||
| if: ${{ failure() }} | ||
| with: | ||
| name: logs-test-${{ matrix.module }}-${{ github.run_number}}#${{ github.run_attempt }} | ||
| path: ${{ runner.temp }}/fluss-logs/* | ||
| - name: Upload JaCoCo coverage report | ||
| uses: actions/upload-artifact@v4 | ||
| if: ${{ success() && github.ref == 'refs/heads/main' }} | ||
| with: | ||
| name: jacoco-report-${{ matrix.module }}-${{ github.run_number}}#${{ github.run_attempt }} | ||
| path: ${{ github.workspace }}/fluss-test-coverage/target/site/jacoco-aggregate/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| ################################################################################ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| ################################################################################ | ||
| name: Nightly | ||
| on: | ||
| schedule: | ||
| # Run at 20:00 UTC daily which is the lowest traffic time for Fluss project. | ||
| - cron: "0 20 * * *" | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.number || github.run_id }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-on-jdk8: | ||
| name: "Java 8" | ||
| uses: ./.github/workflows/ci-template.yaml | ||
| with: | ||
| java-version: "8" | ||
| maven-parameters: "-Pjava8" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it can be renamed to 'build-on-jdk8' here to be consistent with 'build-on-jdk11' below？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this test, I just want to compile on jdk8 but not run, thus I want to distingush with 'build-on-jdk11' . Because run both jdk 8 and 11 will cost too much time for each code pull request. I add a daily run test on jdk8.