[server] Support generate and execute reblance plan #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
rebalance-plan
branch
9 times, most recently
from
061ed6b to
6bf4aca
Compare
swuferhong
force-pushed
the
rebalance-plan
branch
from
6bf4aca to
d67fc39
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
swuferhong
force-pushed
the
rebalance-plan
branch
from
d67fc39 to
780e238
Compare
swuferhong
force-pushed
the
rebalance-plan
branch
3 times, most recently
from
967ccb0 to
85341ca
Compare
LiebingYu
reviewed
Sep 11, 2025
Comment on lines
+561
to
+607
| message ListRebalanceProcessResponse { | ||
| repeated PbRebalanceProcessForTable process_for_table = 1; | ||
| } |
Contributor
There was a problem hiding this comment.
I have a question here. Rebalance task are store in CoordinatorContext via Map<TableBucket, RebalanceResultForBucket>, and Admin#listRebalanceProcess alse return Map<TableBucket, RebalanceResultForBucket>. So can we directly use the following format?
message ListRebalanceProcessResponse {
repeated PbRebalanceProcessForBucket process_for_bucket = 1;
}
message PbRebalanceProcessForBucket {
required int64 table_id = 1;
required int64 partition_id = 2;
required int32 bucket_id = 3;
repeated int32 original_replicas = 4 [packed = true];
repeated int32 new_replicas = 5 [packed = true];
required int32 rebalance_status = 6;
}
swuferhong
force-pushed
the
rebalance-plan
branch
3 times, most recently
from
60fd7ef to
ed3a37a
Compare
LiebingYu
reviewed
Oct 24, 2025
| @Override | ||
| public CompletableFuture<RebalanceResponse> rebalance(RebalanceRequest request) { | ||
| throw new UnsupportedOperationException("Support soon!"); | ||
| List<Goal> goalsByPriority = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
Missing permission control?
| public CompletableFuture<CancelRebalanceResponse> cancelRebalance( | ||
| CancelRebalanceRequest request) { | ||
| throw new UnsupportedOperationException("Support soon!"); | ||
| rebalanceManagerSupplier.get().cancelRebalance(); |
| return new LeaderAndIsr(leader, leaderEpoch, newIsr, coordinatorEpoch, bucketEpoch + 1); | ||
| } | ||
|
|
||
| public LeaderAndIsr newLeaderAndIsrWithNewLeaderEpoch() { |
swuferhong
force-pushed
the
rebalance-plan
branch
from
f391276 to
b03b9eb
Compare
swuferhong
force-pushed
the
rebalance-plan
branch
from
b03b9eb to
270af0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #1397
Brief change log
Tests
API and Format
Documentation