Skip to content

Conversation

@beryllw
Copy link
Contributor

@beryllw beryllw commented Oct 18, 2025

Purpose

Linked issue: close #1821

Brief change log

Partitions in Fluss Tiering split are Strings, but Iceberg partition transforms require data in actual types. For now, we throw an exception and will implement the type conversion later.

Tests

API and Format

Documentation

@beryllw beryllw force-pushed the lake-icberg-notstring-partition-throw-ex branch from 38ab166 to 287205c Compare October 18, 2025 04:11
@beryllw beryllw force-pushed the lake-icberg-notstring-partition-throw-ex branch from 3d1274a to 1b0c4a5 Compare October 18, 2025 04:22
@luoyuxia luoyuxia requested a review from Copilot October 20, 2025 01:20
@luoyuxia luoyuxia self-assigned this Oct 20, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to reject partition keys with non-String types in Iceberg lake tables, as the current implementation only supports String partition types. This is a temporary measure with a TODO to implement proper type conversion in the future.

Key changes:

  • Added validation in IcebergLakeCatalog to throw InvalidTableException when partition keys are not of String type
  • Added parameterized test to verify the validation works for both primary key and log tables

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
IcebergLakeCatalog.java Added validation to reject non-String partition key types with appropriate error message
IcebergLakeCatalogTest.java Added parameterized test case to verify non-String partition keys are properly rejected
Comments suppressed due to low confidence (1)

fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/IcebergLakeCatalog.java:1

  • Corrected grammar: 'support' should be 'supports' to match singular subject.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beryllw Thanks for the pr. Only one comment. PTAL

@luoyuxia luoyuxia merged commit 61475a8 into apache:main Oct 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[lake/iceberg] thrown Exception when partition columns are of non-String type

2 participants