Fix thread-safety problem of PrimaryKeyLoookuper and PrefixKeyLookuper #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beryllw
reviewed
Oct 31, 2025
fluss-client/src/main/java/org/apache/fluss/client/lookup/PrefixKeyLookuper.java
Outdated
Show resolved
Hide resolved
platinumhamburg
force-pushed
the
lookuper-thread-safety
branch
2 times, most recently
from
7e6d2ae to
ef1265c
Compare
wuchong
force-pushed
the
lookuper-thread-safety
branch
from
ef1265c to
608d566
Compare
wuchong
approved these changes
Nov 27, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Thanks @platinumhamburg , this pull request is in high code quality with strong test coverage. I only improved some minor problems. I will merge it once CI is passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1914
Brief change log
Tests
API and Format
Documentation