-
Notifications
You must be signed in to change notification settings - Fork 460
pass catalog sensitive info when create fluss catalog #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
34c93df
pass catalog sensitive info when create fluss catalog
xx789633 75a034c
nit
xx789633 6e43bd8
rename
xx789633 db330cb
rename
xx789633 038e69e
wip: pass all types of lake formats
xx789633 2531fd8
refactor
xx789633 e8f3cf6
rename
xx789633 37db330
Merge branch 'apache:main' into lakesense
xx789633 6dd0607
fix quickstart sql
xx789633 544344f
refactor
xx789633 3f5f7d8
fix compile
xx789633 9291067
isolate PREFIXES_TO_SKIP_VALIDATE
xx789633 af27626
remove quick start
xx789633 bf03205
remove quick start
xx789633 6598ddf
Merge branch 'main' into lakesense
xx789633 51760d9
remove reduant code
xx789633 715997d
supplier
xx789633 7de5bd6
fix
xx789633 3b415a2
add test
xx789633 a6a1fb9
move
xx789633 c14537a
move
xx789633 a0f1591
Merge branch 'main' into lakesense
xx789633 18b017f
rebase
xx789633 32826f5
rename
xx789633 15de5fd
fix supplier
xx789633 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,7 +64,8 @@ public void testCreateCatalog() { | |
| DB_NAME, | ||
| BOOTSTRAP_SERVERS_NAME, | ||
| Thread.currentThread().getContextClassLoader(), | ||
| Collections.emptyMap()); | ||
| Collections.emptyMap(), | ||
| Collections::emptyMap); | ||
|
|
||
| checkEquals(flinkCatalog, actualCatalog); | ||
|
|
||
|
|
@@ -75,7 +76,12 @@ public void testCreateCatalog() { | |
| securityMap.put("client.security.sasl.username", "root"); | ||
| securityMap.put("client.security.sasl.password", "password"); | ||
|
|
||
| Map<String, String> lakeCatalogMap = new HashMap<>(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add test in
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a new test |
||
| lakeCatalogMap.put("paimon.jdbc.user", "admin"); | ||
| lakeCatalogMap.put("paimon.jdbc.password", "pass"); | ||
|
|
||
| options.putAll(securityMap); | ||
| options.putAll(lakeCatalogMap); | ||
| FlinkCatalog actualCatalog2 = | ||
| (FlinkCatalog) | ||
| FactoryUtil.createCatalog( | ||
|
|
@@ -85,6 +91,7 @@ public void testCreateCatalog() { | |
| Thread.currentThread().getContextClassLoader()); | ||
|
|
||
| assertThat(actualCatalog2.getSecurityConfigs()).isEqualTo(securityMap); | ||
| assertThat(actualCatalog2.getLakeCatalogProperties()).isEqualTo(lakeCatalogMap); | ||
| } | ||
|
|
||
| @Test | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done