[KV] Support configurable change log image mode for Primary Key Tables #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumhamburg
force-pushed
the
ignore-hb
branch
from
64270e1 to
0844d64
Compare
wuchong
reviewed
Dec 11, 2025
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
wuchong
reviewed
Dec 18, 2025
Member
There was a problem hiding this comment.
Thanks for the updates, the refactoring and method extraction of KvTablet is very nice!
Could you add an Flink IT Case that updates and deletes to a table with WAL mode + default merge engine, and then (1) read and verify the changelogs of the table. (2) Do aggregation on the table and produce correct final result (verify there is a ChangelogNormalze node generated for the source to guarantee a normalized changelog for aggregation).
fluss-common/src/main/java/org/apache/fluss/metadata/ChangelogImage.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/org/apache/fluss/server/kv/KvTabletTest.java
Outdated
Show resolved
Hide resolved
Member
|
I appended a commit to add back some code comments of |
Contributor
Author
|
@wuchong I'v updated this PR and resolved all comments, thanks for review again. |
platinumhamburg
changed the title
wuchong
approved these changes
Dec 19, 2025
platinumhamburg
added a commit
to platinumhamburg/fluss
that referenced
this pull request
Dec 20, 2025
…age mode for Primary Key Tables (apache#2105)" This reverts commit e5d10ac.
vamossagar12
pushed a commit
to vamossagar12/fluss
that referenced
this pull request
Dec 20, 2025
… for Primary Key Tables (apache#2105) Co-authored-by: Jark Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2102
Brief change log
Tests
API and Format
Documentation