Skip to content

Conversation

@rionmonster
Copy link
Contributor

Purpose

Linked issue: close #2113

Per Issue #2113, this pull request upgrades the existing Maven version referenced within Fluss to the latest stable release. The motivation behind this being that the current version (3.8.6) is no longer supported or maintained.

Brief change log

Upgraded the Maven wrapper using the built-in utility call to target the latest stable release and generate all of the necessary artifacts:

./mvnw -N wrapper:wrapper -Dmaven=3.9.11

Tests

N/A

API and Format

N/A

Documentation

N/A

@rionmonster
Copy link
Contributor Author

@wuchong

I was looking into this issue and based on the previously touched files, I figured that you'd be the person to ask. I was running into local issues when working on a separate issue related to Maven and noticed the version we are targeting is no longer supported.

I attempted to upgrade it (along with its references), but noticed that this caused the Maven Enforcer plugin to fail the CI builds for Java 11 since it defaults to Maven 3.8.6, which doesn't fall into the updated enforcement range introduced in this pull request (from <version>[3.8.6,)</version> to <version>[3.9.11,)</version>). I'm not certain what the best course of action here would be, so I wanted your feedback.

My initial approaches would be:

  • Leverage Maven Wrapper for CI - Currently the CI builds call Maven directly (e.g. mvn ...) however I'm curious if we could update the CI template to use the wrapper as well (uncertain how feasible this is) for consistency across the different builds.
  • Specifying Build Version - Update the existing Java 11 CI builds to explicitly set the Maven version to the new target of 3.9.11.
  • Relaxing Enforcement - Just revert the target enforcement version to the previous 3.8.6 to support these older versions. IMO, not ideal since I think we want to get away from those deprecated versions everywhere, but it would support the CI use case.

@rionmonster
Copy link
Contributor Author

Closing based on discussion within #2113 to keep the target version of Fluss in line with that of Flink (3.8.6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build] Upgrade Maven to Latest Supported Version

1 participant