-
Notifications
You must be signed in to change notification settings - Fork 458
[kv] Add an implementation of AutoIncIDBuffer #2161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
beryllw
wants to merge
10
commits into
apache:main
Choose a base branch
from
beryllw:auto-inc-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
697dbcf
[kv] Add an implementation of AutoIncIDBuffer
beryllw 9848c65
[kv] format code
beryllw 4cba163
[kv] fix ci
beryllw 1f4f4c3
[kv] fix java8 compile
beryllw 6d4a2ec
[kv] fix ci
beryllw b3edf78
rm prefetch and two segment optimize
beryllw c92eb94
rm unused change
beryllw 2401a64
fix ci
beryllw 7c619ca
fix ci
beryllw 5d1fc42
fix review comment
beryllw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
fluss-server/src/main/java/org/apache/fluss/server/kv/autoinc/AutoIncColumnProcessor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.server.kv.autoinc; | ||
|
|
||
| import org.apache.fluss.metadata.KvFormat; | ||
| import org.apache.fluss.metadata.Schema; | ||
| import org.apache.fluss.record.BinaryValue; | ||
| import org.apache.fluss.row.InternalRow; | ||
| import org.apache.fluss.row.encode.RowEncoder; | ||
| import org.apache.fluss.types.DataType; | ||
|
|
||
| import javax.annotation.Nullable; | ||
| import javax.annotation.concurrent.NotThreadSafe; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| /** A updater to auto increment column . */ | ||
| @NotThreadSafe | ||
| public class AutoIncColumnProcessor implements AutoIncProcessor { | ||
|
|
||
| private final InternalRow.FieldGetter[] flussFieldGetters; | ||
|
|
||
| private final RowEncoder rowEncoder; | ||
|
|
||
| private final DataType[] fieldDataTypes; | ||
| private final Map<Integer, IncIDGenerator> idGeneratorMap; | ||
| private final short schemaId; | ||
|
|
||
| public AutoIncColumnProcessor( | ||
| KvFormat kvFormat, | ||
| short schemaId, | ||
| Schema schema, | ||
| int[] targetColumnIdx, | ||
| IncIDGenerator[] incIDGenerator) { | ||
| this.idGeneratorMap = new HashMap<>(); | ||
| for (int i = 0; i < targetColumnIdx.length; i++) { | ||
| idGeneratorMap.put(targetColumnIdx[i], incIDGenerator[i]); | ||
| } | ||
| this.fieldDataTypes = schema.getRowType().getChildren().toArray(new DataType[0]); | ||
|
|
||
| // getter for the fields in row | ||
| flussFieldGetters = new InternalRow.FieldGetter[fieldDataTypes.length]; | ||
| for (int i = 0; i < fieldDataTypes.length; i++) { | ||
| flussFieldGetters[i] = InternalRow.createFieldGetter(fieldDataTypes[i], i); | ||
| } | ||
| this.rowEncoder = RowEncoder.create(kvFormat, fieldDataTypes); | ||
| this.schemaId = schemaId; | ||
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public BinaryValue processAutoInc(BinaryValue oldValue) { | ||
| rowEncoder.startNewRow(); | ||
| for (int i = 0; i < fieldDataTypes.length; i++) { | ||
| if (idGeneratorMap.containsKey(i)) { | ||
| if (oldValue != null && oldValue.row.isNullAt(i)) { | ||
| rowEncoder.encodeField(i, idGeneratorMap.get(i).nextVal()); | ||
| } | ||
| } else { | ||
| // use the old row value | ||
| if (oldValue == null) { | ||
| rowEncoder.encodeField(i, null); | ||
| } else { | ||
| rowEncoder.encodeField(i, flussFieldGetters[i].getFieldOrNull(oldValue.row)); | ||
| } | ||
| } | ||
| } | ||
| return new BinaryValue(schemaId, rowEncoder.finishRow()); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial update is required, so the data type here needs to be temporarily set to nullable.