Skip to content

[kv] include hidden potential internal flush time in KV flush latency #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuston wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[kv] include hidden potential internal flush time in KV flush latency #2206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fluss-server/src/main/java/org/apache/fluss/server/kv/prewrite/KvPreWriteBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ public void truncateTo(long targetLogSequenceNumber, TruncateReason truncateReas
* be flushed
*/
public void flush(long exclusiveUpToLogSequenceNumber) throws IOException {
long start = System.nanoTime();
int flushedCount = 0;
for (Iterator<KvEntry> it = allKvEntries.iterator(); it.hasNext(); ) {
KvEntry entry = it.next();
Expand Down Expand Up @@ -236,7 +237,6 @@ public void flush(long exclusiveUpToLogSequenceNumber) throws IOException {
}
// flush to underlying kv tablet
if (flushedCount > 0) {
long start = System.nanoTime();
kvBatchWriter.flush();
flushCount.inc();
flushLatencyHistogram.update((System.nanoTime() - start) / 1_000_000);
Expand Down