Skip to content

Conversation

@gyang94
Copy link
Contributor

@gyang94 gyang94 commented Mar 5, 2025

Purpose

Linked issue: close #537

Brief change log

Tests

API and Format

Documentation

website/versioned_docs
website/versioned_sidebars
website/versions.json
website/pnpm-lock.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If users build websites with npm, it will generate a lock file called package-lock.json, which has been already included in the git ignore file.
There are other package managers to build node projects, like pnpm and yarn. They will also generate lock file called pnpm-lock.yaml or yarn.lock. Generally those lock files should not be included in git, unless we want to "lock" the dependencies's version.
I build it with pnpm locally, thus I added it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation.

@wuchong wuchong merged commit fb7f91f into apache:main Mar 6, 2025
3 checks passed
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move "Developer Guide" from Docs to Community

2 participants