Bump LogRecordBatch's CURRENT_LOG_MAGIC_VALUE to V1 to support leaderEpoch #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
logRecordBatch-add-leaderEpoch
branch
3 times, most recently
from
1a1693f to
e8b5338
Compare
2 tasks
swuferhong
force-pushed
the
logRecordBatch-add-leaderEpoch
branch
2 times, most recently
from
ea098f3 to
875f12f
Compare
Contributor
Author
|
@wuchong pr ready, could you take a look at this pr? thx. |
swuferhong
force-pushed
the
logRecordBatch-add-leaderEpoch
branch
2 times, most recently
from
e3dd71e to
03c9bbe
Compare
Contributor
platinumhamburg
left a comment
platinumhamburg
left a comment
There was a problem hiding this comment.
This PR LGTM. However, there are some minor issues: several test cases hardcode the CURRENT_LOG_MAGIC_VALUE magic value. It would be better to parameterize these related test cases.
...ient/src/test/java/com/alibaba/fluss/client/table/scanner/log/DefaultCompletedFetchTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/com/alibaba/fluss/record/MemoryLogRecordsArrowBuilderTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/com/alibaba/fluss/record/MemoryLogRecordsArrowBuilderTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/com/alibaba/fluss/record/MemoryLogRecordsArrowBuilderTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/com/alibaba/fluss/record/MemoryLogRecordsArrowBuilderTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@platinumhamburg comments addressed |
swuferhong
force-pushed
the
logRecordBatch-add-leaderEpoch
branch
2 times, most recently
from
3495486 to
3b33f5f
Compare
polyzos
force-pushed
the
main
branch
3 times, most recently
from
d88c76c to
434a4f4
Compare
wuchong
reviewed
Sep 9, 2025
fluss-common/src/main/java/org/apache/fluss/record/LogRecordBatchFormat.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/DefaultLogRecordBatch.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/FileLogProjection.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/org/apache/fluss/record/LogRecordBatchFormat.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/org/apache/fluss/testutils/DataTestUtils.java
Outdated
Show resolved
Hide resolved
wuchong
approved these changes
Sep 9, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
I pushed a commit to address the above comments. Please review the changes. @swuferhong
wuchong
force-pushed
the
logRecordBatch-add-leaderEpoch
branch
from
3b33f5f to
b60e2a1
Compare
Contributor
Author
|
@wuchong LGTM, the CI has been failed. |
Contributor
|
I think this PR affects a lot also this, right? |
Member
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 10, 2025
…leaderEpoch (apache#778) Co-authored-by: Jark Wu <[email protected]> # Conflicts: # fluss-client/src/test/java/org/apache/fluss/client/write/IndexedLogWriteBatchTest.java # fluss-common/src/main/java/org/apache/fluss/record/MemoryLogRecordsIndexedBuilder.java
swuferhong
added a commit
to luoyuxia/fluss
that referenced
this pull request
Sep 17, 2025
…support leaderEpoch (apache#778)" This reverts commit a25c64b.
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 21, 2025
…leaderEpoch (apache#778) Co-authored-by: Jark Wu <[email protected]>
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Sep 21, 2025
…leaderEpoch (apache#778) Co-authored-by: Jark Wu <[email protected]>
loserwang1024
added a commit
to loserwang1024/fluss
that referenced
this pull request
Sep 26, 2025
…support leaderEpoch (apache#778)" This reverts commit a25c64b.
leosanqing
pushed a commit
to leosanqing/fluss
that referenced
this pull request
Sep 29, 2025
…leaderEpoch (apache#778) Co-authored-by: Jark Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #749
Currently, Fluss uses HighWatermark to ensure data synchronization between the leader and followers. However, this approach can lead to data loss or data inconsistency during cluster upgrades or when tabletServers crash. Referencing Kafka KIP-101, we plan to replace the HighWatermark mechanism in Fluss with a leader epoch update mechanism.
To achieve this goal, we need to build a consistent LeaderEpochCache across different tabletServers. The update of this LeaderEpochCache relies on the fetchLogRequest pulling the leader's RecordBatch and reading the LeaderEpoch from the batch to update the cache.
Currently, the LogRecordBatch does not include the LeaderEpoch, so it needs to be introduced, and the magic version of LogRecordBatch should be upgraded accordingly.
Brief change log
Tests
API and Format
Documentation