Open
Conversation
infvg
force-pushed
the
icebergtemp
branch
5 times, most recently
from
42bbb39 to
401cd86
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
infvg
force-pushed
the
icebergtemp
branch
2 times, most recently
from
55f2646 to
4b89431
Compare
zhouyuan
reviewed
Apr 1, 2026
| SparkShimLoader.getSparkShims.isRowIndexMetadataColumn(field.name); | ||
| } | ||
| } | ||
| StructType(filteredFields) |
Member
There was a problem hiding this comment.
also need to filter out those columns in the native code
https://github.com/apache/gluten/blob/main/cpp/velox/compute/iceberg/IcebergWriter.cc#L215
zhouyuan
reviewed
Apr 1, 2026
| val filteredFields = schema.fields.filterNot { | ||
| field => | ||
| { | ||
| SparkShimLoader.getSparkShims.isRowIndexMetadataColumn(field.name); |
Member
There was a problem hiding this comment.
it looks like this method is for delta only
infvg
force-pushed
the
icebergtemp
branch
5 times, most recently
from
88409b0 to
66cf81c
Compare
Co-authored-by: Yuan <yuanzhou@apache.org>
infvg
force-pushed
the
icebergtemp
branch
2 times, most recently
from
3c0f677 to
4b9196b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?