Skip to content

Conversation

@Blazer-007
Copy link
Member

@Blazer-007 Blazer-007 commented Sep 18, 2025

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Made the DagActionChangeMonitor, SpecStoreChangeMonitor config driven initialization
    Also changed DagActionChangeMonitor, SpecStoreChangeMonitor and JobStatusMonitor to bind using interface in place of Abstract class

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    NA

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Blazer-007 Blazer-007 changed the title [GOBBLIN-XXX] Make dag action and spec store monitor initialization config driven [GOBBLIN-2227] Make dag action and spec store monitor initialization config driven Sep 18, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.75%. Comparing base (26b3b77) to head (f7dc419).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4141      +/-   ##
============================================
- Coverage     42.81%   38.75%   -4.07%     
+ Complexity     2480     1598     -882     
============================================
  Files           513      388     -125     
  Lines         21744    16018    -5726     
  Branches       2478     1589     -889     
============================================
- Hits           9309     6207    -3102     
+ Misses        11481     9313    -2168     
+ Partials        954      498     -456     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/**
* A marker interface for dag action change monitors to generalize initialization in {@link org.apache.gobblin.service.modules.core.GobblinServiceManager#dagManagementDagActionStoreChangeMonitor}
*/
public interface DagActionChangeMonitor extends Service {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we are extending Service class, we can explore startAsync / awaitRunning method from that. setActive might not be required then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is extending Service only due to its initialization https://github.com/apache/gobblin/blob/master/gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java#L276 startAsync / awaitRunning is implemented by AbstractIdleService which is further extended by HighLevelConsumer, we can look to refactor in better way these later

Copy link
Contributor

@thisisArjit thisisArjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aga9900 aga9900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blazer-007 Blazer-007 merged commit 756c580 into apache:master Sep 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants