Evolve schema for Iceberg table for partition copy #4145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisArjit
force-pushed
the
schema-evolution-iceberg-partition
branch
from
abcef82 to
6325883
Compare
Blazer-007
reviewed
Oct 15, 2025
Comment on lines
+324
to
+342
| */ | ||
| public void updateSchema(Schema updatedSchema) throws TableNotFoundException { | ||
| TableMetadata currentTableMetadata = accessTableMetadata(); | ||
| Schema currentSchema = currentTableMetadata.schema(); | ||
|
|
||
| if (currentSchema.sameSchema(updatedSchema)) { | ||
| log.info("~{}~ schema is already up-to-date", tableId); | ||
| return; | ||
| } | ||
|
|
||
| log.info("~{}~ updating schema from {} to {}", tableId, currentSchema, updatedSchema); | ||
|
|
||
| TableMetadata updatedTableMetadata = currentTableMetadata.updateSchema(updatedSchema, updatedSchema.highestFieldId()); | ||
| Preconditions.checkArgument(updatedTableMetadata.schema().sameSchema(updatedSchema), "Schema mismatch after update, please check destination table"); | ||
|
|
||
| tableOps.commit(currentTableMetadata, updatedTableMetadata); | ||
| tableOps.refresh(); | ||
|
|
||
| log.info("~{}~ schema updated successfully", tableId); |
Member
There was a problem hiding this comment.
Lets not update schema here itself, since we haven't copied files yet updating schema will leave table in unwanted state if copying files fail due to any reason
Member
There was a problem hiding this comment.
Also schema update and data files commit should be done in one transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits