Skip to content

Conversation

@abhishekmjain
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    As part of this PR, we are fixing the scenario where an extra owner permission is set for Manifest based copy if the path already exists in destination.

We are capturing the directories in a new map while traversing and updating the same in post publish step.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Added 3 unit tests to verify the behaviour

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@abhishekmjain abhishekmjain merged commit 7c54b95 into apache:master Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants