[GOBBLIN-2234] Fix removal of existing ACLs issue for path existing in destination

[abhishekmjain]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-2234] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-2234

Description

• Here are some details about my PR, including screenshots (if applicable):
  ACLs are not removed if a source directory already exists in destination. As part of this PR, we are fixing the issue.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  Added multiple unit tests

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[Copilot]

Pull Request Overview

This PR adds support for removing existing ACLs before setting new ones to ensure exact ACL matching between source and destination during file copy operations. The key change is the introduction of a removeExistingAcls parameter to prevent ACL accumulation when copying files.

• Added a new overloaded setPathPermission method with a removeExistingAcls parameter
• Updated CopyDataPublisher to use the new parameter with removeExistingAcls=true to ensure exact ACL matching
• Enhanced the test infrastructure with comprehensive test coverage for ACL removal scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
FileAwareInputStreamDataWriter.java	Added overloaded setPathPermission method with removeExistingAcls parameter and logic to call removeAcl when needed
CopyDataPublisher.java	Updated to pass removeExistingAcls=true when preserving file attributes to ensure exact ACL matching
FileAwareInputStreamDataWriterTest.java	Added 9 new test cases for ACL removal scenarios and enhanced TestLocalFileSystem to track removeAcl calls

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.