Skip to content

Conversation

@abhishekmjain
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Reduce Commit workflow impl output size by removing dataset urns specific properties.
    Aggregate them and add to CommitStats.
    Send the same properties to ExecuteGobblinStats.
    Update the place of creation of JobSummaryEvent to CommitActivity instead of CommitWorkflow.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.90%. Comparing base (756c580) to head (89d25c8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...temporal/ddm/activity/impl/CommitActivityImpl.java 46.15% 7 Missing ⚠️
.../ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4151      +/-   ##
============================================
- Coverage     48.02%   47.90%   -0.12%     
- Complexity     8542     8549       +7     
============================================
  Files          1601     1602       +1     
  Lines         63933    64000      +67     
  Branches       7211     7216       +5     
============================================
- Hits          30702    30662      -40     
- Misses        30469    30565      +96     
- Partials       2762     2773      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratapaditya04
Copy link
Contributor

pratapaditya04 commented Oct 31, 2025

@abhishekmjain checkstyle is failing, please check

@abhishekmjain abhishekmjain merged commit 8ba6c1f into apache:master Nov 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants