Fix profile resolution in grails-shell-cli #14689
Merged
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
changed the title
|
#14691 will fix the invalid pom. FYI: if you want to generate a valid pom, you must adhere to the correct maven scopes, so I've mapped profile api => runtime, and profile runtime => compile. |
|
I believe this is obsoleted by #14691 |
jamesfredley
commented
May 2, 2025
| @@ -17,13 +17,11 @@ skeleton: | |||
| executable: ["**/gradlew*", "**/grailsw*"] | |||
| binaryExtensions: ['png','gif','jpg','jpeg','ico','icns','pdf','zip','jar','class'] | |||
| repositories: | |||
| - "https://repo1.maven.org/maven2" | |||
| - "https://repository.apache.org/content/groups/snapshots" | |||
| - "https://repository.apache.org/content/groups/public" | |||
There was a problem hiding this comment.
#14706 - issue to adjust this on non SNAPSHOT builds
jdaugherty
approved these changes
May 2, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Apache Grails 7.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the code back to a single repository, instead of trying to use two. It uses apache when grailsVersion is a SNAPSHOT
This PR gives you a grails-shell-cli distribution that will download the profiles based on grails-bom, including SNAPSHOTS, and generate a functioning web profile application.