Define inputs and outputs for Gradle task createStartScripts #14714
+46
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures /lib directory is complete before StartScripts are generated
jdaugherty
reviewed
May 6, 2025
jdaugherty
reviewed
May 6, 2025
jdaugherty
requested changes
May 6, 2025
There was a problem hiding this comment.
I'm against tying unrelated tasks together in Gradle since it prevents the build from being fully parallel. I think I'm missing something since the task that was modified dealt with the wrapper scripts, which is independent of the cli dependencies task (other than an input). Can you help me understand this relation?
…lasspath to pre-project merger.
|
@jamesfredley as discussed, I reworked the distribution to use the built application plugin. This change will use the grails-shell-cli project to build the "distribution". The gradle tasks are documented here and they exist under the grails-shell-cli gradle project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures /lib directory is complete before StartScripts are generated