feature - #14017 - add back Micronaut support to Grails 7 with optional plugin#14953
feature - #14017 - add back Micronaut support to Grails 7 with optional plugin#14953jdaugherty merged 22 commits into7.0.xfrom
Conversation
dc7a7d4 to
0952435
Compare
|
@amacleay-cohere @ysb33r @rlconst latest update on Micronaut support for Grails 7 |
3638832 to
b5c8513
Compare
9bfe90d to
594b6eb
Compare
5f9bf1a to
3fcdde0
Compare
3891886 to
37dba4e
Compare
|
@graemerocher or @sdelamo if either of you have any feedback on this change, it would be helpful. I am not as familiar with the micronaut project dependencies - for example, should the micronaut cache library still be included? I also took the approach that Grails 6 took: the gradle plugin has some logic to make it just "work" for the end user. The tests are limited in grails-core, but they are passing. My guess is we'll merge this and then make any incremental changes if there's specific feedback. |
065a8e0 to
09e06a3
Compare
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
97ff0ec to
6032ef1
Compare
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Show resolved
Hide resolved
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Show resolved
Hide resolved
grails-test-examples/micronaut/grails-app/init/micronaut/BootStrap.groovy
Outdated
Show resolved
Hide resolved
...est-examples/micronaut/src/integration-test/groovy/micronaut/BeanInjectionServiceSpec.groovy
Show resolved
Hide resolved
matrei
left a comment
There was a problem hiding this comment.
Some questions and suggestions.
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
|
The scaffolding failure was caused by the setters() having I'm still concerned about the lack of test coverage, other than the functional test apps, but I think users can try this out in the RC2 and we can go from there. @jamesfredley @matrei the bean wiring will likely have further issues - anywhere we use a setter with
A lot of these seem related to a change to support multiple message sources (438d2e0) Do we fix these to say it's supported? Prior versions of grails had a limited number of micronaut beans, so the grails beans weren't a micronaut bean by default. I'm skeptical people were accessing these beans from micronaut, so we may be able to make this change gradually. |
|
It seems moving to constructor injection created another issue? |
Odd, this didn't fail locally when I ran through all of the tests. Will take a look. |
…equire it as an exported dependency
|
@matrei This should be fixed now (https://ge.grails.org/s/6nvk6sdfjpzre) |
|
The forge failures are b/c of the asset pipeline depending on the grails-dependencies-web and we have moved the i18n plugin. I'd rather merge this + publish a new asset pipeline + update the version of the asset pipeline than try to add an exclude for that library. @jamesfredley @matrei thoughts? |
|
@jdaugherty Since you need this merged and published to use the new i18n coordinates to then update and release asset-pipeline, I think we can ignore the failures. |
|
I'll publish an asset pipeline release once we get sign off on this then. @matrei / @jamesfredley let me know when you think this is ready. |
.../plugins/src/main/groovy/org/grails/gradle/plugin/views/gsp/GroovyPageForkCompileTask.groovy
Outdated
Show resolved
Hide resolved
...in-class/src/main/groovy/org/grails/plugins/domain/GrailsDomainClassAutoConfiguration.groovy
Show resolved
Hide resolved
...in-class/src/main/groovy/org/grails/plugins/domain/GrailsDomainClassAutoConfiguration.groovy
Outdated
Show resolved
Hide resolved
...in-class/src/main/groovy/org/grails/plugins/domain/GrailsDomainClassAutoConfiguration.groovy
Outdated
Show resolved
Hide resolved
...in-class/src/main/groovy/org/grails/plugins/domain/GrailsDomainClassAutoConfiguration.groovy
Outdated
Show resolved
Hide resolved
...in-class/src/main/groovy/org/grails/plugins/domain/GrailsDomainClassAutoConfiguration.groovy
Outdated
Show resolved
Hide resolved
grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/GroovyPagesPostProcessor.groovy
Outdated
Show resolved
Hide resolved
grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/GroovyPagesPostProcessor.groovy
Outdated
Show resolved
Hide resolved
grails-micronaut/src/main/groovy/org/apache/grails/micronaut/GrailsMicronautGrailsPlugin.groovy
Outdated
Show resolved
Hide resolved
cbdc812 to
6507fc8
Compare
c16b95f to
a6c3581
Compare
Fixes #14017
grails-micronautas a dependency andmicronautPlatformVersionas a gradle property