Open
Conversation
Contributor
Author
|
@jdaugherty can you trigger the workflows so i can see the build status |
Contributor
Author
|
@jdaugherty all checks are successful , please review my pr and let me know if changes are required from my end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added plugin best practices documentation
i worked on adding comprehensive documentation for plugin best practices as mentioned in issue #15326. honestly it took me quite a while to understand all the different aspects of plugin development in grails 7 but i think i got most of it covered.
what i did:
the documentation is in the usual grails doc format with asciidoctor syntax. i tried to make it practical with real examples instead of just theory. hope i got everything right - please let me know if anything needs fixing.
files i touched: