Draft
Conversation
Update date formats for data binding documentation
Signed-off-by: Ajay <chinniyadav9704@gmail.com>
Contributor
Author
|
@jdaugherty can you let me know anything that needs to be updated and also please trigger the workflows so i can verify and check if anything goes wrong |
jdaugherty
reviewed
Jan 27, 2026
|
|
||
| environments { | ||
|
|
||
| // You need to configure in Safari -> Develop -> Allowed Remote Automation |
Contributor
There was a problem hiding this comment.
I don't think this is correct. We containerized Geb and no longer use a local browser for testing.
jdaugherty
reviewed
Jan 27, 2026
grails-profiles-tests/.travis.yml
Outdated
| @@ -0,0 +1,23 @@ | |||
| jdk: | |||
| - oraclejdk8 | |||
| addons: | |||
Contributor
There was a problem hiding this comment.
We do not use travis. Can you please convert this project to a subproject of grails-core?
|
The GebConfig.groovy file configures local browser drivers (Chrome, Firefox, Safari), but since Geb is now containerized, this setup won't work. You should update it to use a remote WebDriver pointing to the containerized browser instance instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on issue #14700 to bring back the profile testing functionality that was lost when the old shell scripts were removed. This was my first major contribution to Apache Grails, and I wanted to make sure I understood the problem thoroughly before implementing a solution.
What I found
When I dug into this issue, I discovered that the original profile tests were shell scripts that got removed in commit 9b8fa17 because they were outdated and needed reworking. These tests were quite comprehensive - they would create actual Grails applications using different profiles, run various grails commands, and even included functional tests with Geb/Selenium.
My approach
Instead of simply restoring the old shell scripts, I decided to modernize the approach by converting them to proper Gradle-based tests. I created a new grails-profiles-tests module that:
Uses Spock framework for testing (which fits well with the existing Grails ecosystem)
Leverages Grails Forge for programmatic application generation
Tests all the key profile functionality (web, plugin, rest-api profiles)
Includes both unit/integration tests and functional tests
Works cross-platform (Windows, Linux, macOS)
Integrates cleanly with the existing Gradle build system
What's included
The solution provides comprehensive test coverage that verifies:
Profile directory structure creation
Configuration file generation
Profile-specific commands and workflows
Application building and packaging
Functional testing capabilities
I also made sure to preserve the original shell scripts with proper ASF license headers for reference, maintaining backward compatibility while providing the modern testing approach.