7.0.7 + Java 25: Fix for WARNING: Use of the three-letter time zone ID ... is deprecated and it will be removed in a future release by codeconsole · Pull Request #15432 · apache/grails-core

codeconsole · 2026-02-21T23:10:39Z

When using Java 25, all grails applications startup with

> Task :bootRun
WARNING: Use of the three-letter time zone ID "ACT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AGT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ART" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CAT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CTT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EAT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ECT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "HST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "IET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "IST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "JST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MIT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PLT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PRT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "SST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "VST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ART" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "JST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "VST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "IET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PLT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PNT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "EAT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ECT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "PRT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CTT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "SST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "HST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "ACT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "BST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "IST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CST" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "NET" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "AGT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "CAT" is deprecated and it will be removed in a future release
WARNING: Use of the three-letter time zone ID "MIT" is deprecated and it will be removed in a future release
Grails application running at http://localhost:8090 in environment: development

This is due to the legacy FastDateFormat. This PR switches to java.time instead while maintaining backward compatibility.
The messages no longer occur after this fix.

Marshaller	Type	Formatter	Output	Status
`json/DateMarshaller`	`Date`	`ISO_INSTANT`	`2024-06-15T14:30:45.123Z`	just fixed
`json/CalendarMarshaller`	`Calendar`	`ISO_INSTANT`	`2024-06-15T14:30:45.123Z`	just fixed
`json/InstantMarshaller`	`Instant`	`ISO_INSTANT`	`2024-06-15T14:30:45.123Z`	already correct
`json/LocalDateMarshaller`	`LocalDate`	`ISO_LOCAL_DATE`	`2024-06-15`	already correct
`json/LocalDateTimeMarshaller`	`LocalDateTime`	`ISO_LOCAL_DATE_TIME`	`2024-06-15T14:30:45.123`	already correct
`json/OffsetDateTimeMarshaller`	`OffsetDateTime`	`ISO_OFFSET_DATE_TIME`	`2024-06-15T14:30:45.123+02:00`	already correct
`json/ZonedDateTimeMarshaller`	`ZonedDateTime`	`ISO_OFFSET_DATE_TIME`	`2024-06-15T14:30:45.123+02:00`	drops zone name
(consider ISO_ZONED_DATE_TIME? compare with Spring 4 default formatting)
`json/JavascriptDateMarshaller`	`Date`	passes Date to `JSONWriter` (emits JS literal)	`new Date(1718461845123)`	unrelated
to ISO/zones
`xml/DateMarshaller`	`Date`	`ISO_OFFSET_DATE_TIME` (system zone)	`2024-06-15T14:30:45.123-04:00`	just fixed

…ed and it will be removed in a future release

jdaugherty · 2026-02-21T23:11:49Z

We already merged the fix for this ...

jdaugherty · 2026-02-21T23:12:34Z

I guess this is fixing it by changing to the new api instead of the lang update?

codeconsole · 2026-02-21T23:13:13Z

I guess this is fixing it by changing to the new api instead of the lang update?

yeah, but are you sure updating the new api still fixes it?

codeconsole · 2026-02-21T23:15:53Z

@jdaugherty if it was already fixed, why am I still getting the error using the latest 7.1.0-SNAPSHOT?

jdaugherty · 2026-02-21T23:17:41Z

#15417 was merged 11hrs ago, I don't think we have merged up to 7.1.x yet

jdaugherty · 2026-02-22T01:44:30Z

I''ve merged these changes up, can you retest before your changes and see if that fixed it? We will still need to take this API to ultimately update the usages, but I assume we'll do that in 7.1.x instead of 7.0.x? @jamesfredley

jdaugherty

It doesn't look like any tests were added for this change and the default has been changed. This probably should be a 7.1 change.

bito-code-review · 2026-02-25T18:37:11Z

This question isn’t related to the pull request. I can only help with questions about the PR’s code or comments.

Copilot

Pull request overview

This PR addresses Java 25 deprecation warnings by migrating from Apache Commons FastDateFormat (which uses deprecated three-letter timezone IDs) to Java's java.time.format.DateTimeFormatter API. The change maintains backward compatibility by preserving support for custom formatters through a legacyFormatter field.

Changes:

Replaced FastDateFormat with DateTimeFormatter in date/calendar marshallers
Added backward compatibility support for custom formatters via legacyFormatter field
Switched from deprecated three-letter timezone IDs to proper timezone handling

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
grails-converters/src/main/groovy/org/grails/web/converters/marshaller/xml/DateMarshaller.java	Migrated XML date marshaller to use DateTimeFormatter with system default timezone
grails-converters/src/main/groovy/org/grails/web/converters/marshaller/json/DateMarshaller.java	Migrated JSON date marshaller to use DateTimeFormatter with UTC timezone
grails-converters/src/main/groovy/org/grails/web/converters/marshaller/json/CalendarMarshaller.java	Migrated JSON calendar marshaller to use DateTimeFormatter with UTC timezone

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jamesfredley · 2026-02-27T21:55:52Z

Since this doesn't fix a bug, but resolves annoying log lines when running on Java 25 by changing production code, I think this would be safer in 7.1.x.

Cover default DateTimeFormatter output, millisecond padding, UTC conversion, legacy Format fallback, and supports() behavior for json/DateMarshaller, json/CalendarMarshaller, and xml/DateMarshaller. Assisted-by: Claude Code <Claude@Claude.ai>

jdaugherty · 2026-02-27T22:04:19Z

@jamesfredley shouldn't we add functional / integration tests for this too given the impact? we're only testing the lower level stuff with this pr

Add DateMarshallerController and DateMarshallerSpec integration tests to grails-test-examples/app1, exercising the DateTimeFormatter-based marshallers end-to-end through the Grails converters pipeline. Tests cover: - JSON Date marshalling (ISO 8601 UTC format) - JSON Calendar marshalling (ISO 8601 UTC format) - XML Date marshalling (system default timezone format) - 3-digit millisecond padding (.SSS) for both JSON and XML - URL extension-based content negotiation (.json, .xml) Assisted-by: Claude Code <Claude@Claude.ai>

matrei

Can we target 8.0.x?

codeconsole · 2026-04-29T23:20:38Z

Can we target 8.0.x?

@matrei ok

testlens-app · 2026-04-30T03:09:15Z

✅ All tests passed ✅

🏷️ Commit: 0d140fe
▶️ Tests: 15884 executed
⚪️ Checks: 35/35 completed

Learn more about TestLens at testlens.app.

Fix for WARNING: Use of the three-letter time zone ID ... is deprecat…

2fcf832

…ed and it will be removed in a future release

github-project-automation Bot added this to Apache Grails Feb 21, 2026

codeconsole requested a review from matrei February 21, 2026 23:10

codeconsole assigned sbglasius, jdaugherty and jamesfredley Feb 21, 2026

codeconsole requested review from jamesfredley, jdaugherty and sbglasius February 21, 2026 23:11

codeconsole unassigned sbglasius, jdaugherty and jamesfredley Feb 21, 2026

fix formatting

ba0835b

Merge branch '7.0.x' into time-zone-warning-fix

6c3e9b1

jdaugherty reviewed Feb 25, 2026

View reviewed changes

Comment thread ...converters/src/main/groovy/org/grails/web/converters/marshaller/json/CalendarMarshaller.java Outdated

jdaugherty reviewed Feb 25, 2026

View reviewed changes

jdaugherty requested a review from Copilot February 25, 2026 18:37

Copilot started reviewing on behalf of jdaugherty February 25, 2026 18:37 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Comment thread grails-converters/src/main/groovy/org/grails/web/converters/marshaller/xml/DateMarshaller.java Outdated

Merge branch '7.0.x' into time-zone-warning-fix

66ed763

jamesfredley added 2 commits February 27, 2026 18:20

Merge branch '7.0.x' into time-zone-warning-fix

e4b640a

matrei reviewed Apr 28, 2026

View reviewed changes

codeconsole changed the base branch from 7.0.x to 8.0.x April 29, 2026 23:20

codeconsole added 5 commits April 29, 2026 13:23

JDK ISO formatters with chained constructors

d3c8279

fix codestyle

9775744

Merge branch '8.0.x' into time-zone-warning-fix

c755b16

switch to HttpClientSupport

40888f3

fix tests

0d140fe

Uh oh!

Conversation

codeconsole commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdaugherty commented Feb 21, 2026

Uh oh!

jdaugherty commented Feb 21, 2026

Uh oh!

codeconsole commented Feb 21, 2026

Uh oh!

codeconsole commented Feb 21, 2026

Uh oh!

jdaugherty commented Feb 21, 2026

Uh oh!

jdaugherty commented Feb 22, 2026

Uh oh!

Uh oh!

jdaugherty left a comment

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

jamesfredley commented Feb 27, 2026

Uh oh!

jdaugherty commented Feb 27, 2026

Uh oh!

matrei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codeconsole commented Apr 29, 2026

Uh oh!

testlens-app Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All tests passed ✅

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codeconsole commented Feb 21, 2026 •

edited

Loading

testlens-app Bot commented Apr 30, 2026 •

edited

Loading