-
-
Notifications
You must be signed in to change notification settings - Fork 970
feat: Replace Spring Dependency Management plugin with Gradle platform + lightweight BOM property overrides #15467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesfredley
wants to merge
20
commits into
8.0.x
Choose a base branch
from
feat/gradle-managed-version-overrides
base: 8.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ca495ab
feat: replace Spring Dependency Management plugin with Gradle platfor…
jamesfredley 531041b
Address review: add XInclude hardening and extract interpolation dept…
jamesfredley 5e89656
fix: apply grails-bom platform to all declarable configurations
jamesfredley 1a2cea3
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 30a46f6
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 96fea95
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 5607ddb
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 575b77f
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley a4511eb
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 28a6817
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 77932f2
fix: allow Micronaut BOM validator to coexist with plugin-injected pl…
jamesfredley 54fbe93
fix: exclude annotation-processor configurations from grails-bom plat…
jamesfredley 4d1bcdb
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 90c1238
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley a2363ae
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley f0c1934
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 2ca302b
Extract BOM property overrides into a standalone Gradle plugin (PR #1…
jamesfredley bbf5e53
Fix GrailsDependencyValidatorPlugin to prefer enforcedPlatform BOM
jamesfredley 9204972
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley 0178a10
Merge branch '8.0.x' into feat/gradle-managed-version-overrides
jamesfredley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions are only supported by your plugin. Also, the dependency management plugin causes the bom versions to resolve to the spring version and not to the highest version. We should discuss this side effect in the weekly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 2ca302b. The relevant section in
grails-doc/src/en/guide/commandLine/gradleBuild/gradleDependencies.adocnow:Explicitly calls out that the property-override mechanism is a feature of the new
org.apache.grails.gradle.bom-property-overridesplugin and links to Support overriding BOM version properties with ext gradle/gradle#9160 so readers know it isn't native Gradle behaviour.Adds a NOTE block describing the resolution side effect you raised: the plugin participates in Gradle's standard conflict resolution, so when an artifact is requested at multiple versions Gradle's highest-version-wins picks the version, and the property-override pins what wins after that. This contrasts with the legacy Spring DM plugin which forced BOM versions unconditionally and could mask transitive drift.
enforcedPlatform(grails-bom)is documented as the escape hatch for stricter behaviour.Also documents how the new plugin can be applied standalone (non-Grails projects) so the property-override workflow isn't tied to
grails-bom.Happy to refine the side-effect wording further after the weekly discussion - leaving this thread open in case you want to expand on it.