fix: add Groovy proxy support to HibernateProxyHandler.isInitialized()

[jamesfredley]

Summary

• Bug: HibernateProxyHandler.isInitialized() in Hibernate 7 was missing Groovy proxy support, causing uninitialized Groovy proxies to be incorrectly reported as initialized. The fallback Hibernate.isInitialized() returns true for any non-Hibernate object, masking the bug.
• Fix: Add GroovyProxyInterceptorLogic.isInitialized() helper that checks ProxyInstanceMetaClass.isProxyInitiated(), and invoke it from HibernateProxyHandler.isInitialized() before the Hibernate fallback.
• Parity: The Hibernate 5 implementation already had this check. This restores behavioral parity with Hibernate 5.

Changes

File	Change
GroovyProxyInterceptorLogic.java	Add isInitialized(Object) static helper method
HibernateProxyHandler.java	Call GroovyProxyInterceptorLogic.isInitialized() before Hibernate.isInitialized() fallback
HibernateProxyHandler7Spec.groovy	Add test: "test isInitialized for a Groovy proxy before initialization"

Testing

All 21 HibernateProxyHandler7Spec tests pass, including the new Groovy proxy isInitialized test.

[Copilot]

Pull request overview

Adds Groovy proxy awareness to HibernateProxyHandler.isInitialized() in Hibernate 7 to prevent uninitialized Groovy proxies from being incorrectly reported as initialized, restoring behavior parity with Hibernate 5.

Changes:

• Added GroovyProxyInterceptorLogic.isInitialized(Object) tri-state helper for Groovy proxies.
• Updated HibernateProxyHandler.isInitialized() to consult Groovy proxy state before falling back to Hibernate.isInitialized().
• Added a new spec verifying isInitialized returns false for an uninitialized Groovy proxy.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/proxy/GroovyProxyInterceptorLogic.java	Adds Groovy-proxy initialization detection helper.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/proxy/HibernateProxyHandler.java	Uses the Groovy-proxy helper prior to Hibernate fallback.
grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/proxy/HibernateProxyHandler7Spec.groovy	Adds regression test for uninitialized Groovy proxy initialization reporting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 148d718
▶️ Tests: 32256 executed
⚪️ Checks: 30/30 completed

---

Learn more about TestLens at testlens.app.

[jdaugherty]

I'm confused, historically GroovyProxies were not used in hibernate. A different proxy mechanism was used. Was this a change with the hibernate 7 implementation? (see GroovyProxySpec for history)

[jamesfredley]

@jdaugherty

You're right - Groovy proxies (GroovyProxyFactory/ProxyInstanceMetaClass) are not the default proxy mechanism for Hibernate. The TCK GroovyProxySpec is @IgnoreIf for both H5 and H7 with the comment: "this test is ignored because Groovy proxies are not used with Hibernate".

Hibernate uses its own proxy mechanism (ByteBuddy/Javassist HibernateProxy instances). H7's ByteBuddyGroovyProxyFactory creates Hibernate proxies enhanced with Groovy-aware interception - these are NOT "Groovy proxies" in the GroovyProxyFactory sense.

However, H5's HibernateProxyHandler.isInitialized() already had a defensive ProxyInstanceMetaClass check (here) to handle the edge case where someone overrides the proxyFactory (as Hibernate7GroovyProxySpec demonstrates by manually setting proxyFactory = new GroovyProxyFactory()). Without this check, Hibernate.isInitialized() returns true for any non-HibernateProxy object - silently giving wrong answers for Groovy proxies.

This PR restores that same defensive behavior in H7's handler for parity.

[borinquenkid]

It seems correct to me