Hibernate 7 by jdaugherty · Pull Request #15568 · apache/grails-core

jdaugherty · 2026-04-10T14:01:45Z

Reopening. This PR replaces #15530

…style aggregator

…-tck

…hibernate7

- Revert Liquibase Hibernate 7 versions to 4.27.0 for stability. - Add no-arg constructor to GormDatabase for Liquibase service discovery. - Fix JdbcConnection casting in HibernateDatabase. - Update sequence support detection in MissingSequenceChangeGenerator. - Replace removed StringUtil.randomIdentifier in UniqueConstraintSnapshotGenerator. - Update migration specs to support INT and INTEGER type names. - Fix dependency conflicts and JDK 17 compatibility for Derby. - Update SBOM license mapping for liquibase-core.

- Rename Liquibase extension classes with 'Hibernate' prefix to avoid shadowing superclass simple names (fixes NM_SAME_SIMPLE_NAME_AS_SUPERCLASS). - Update service registration files and test sources to reflect class renames. - Fix NP_NONNULL_RETURN_VIOLATION in HibernateConnection by throwing SQLFeatureNotSupportedException instead of returning null. - Fix DM_DEFAULT_ENCODING by specifying UTF-8/StandardCharsets.UTF_8 in multiple files. - Fix potential NP_NULL_ON_SOME_PATH in DatabaseMigrationCommand.groovy with explicit null checks.

- Refactor BasicValueIdCreator to take MetadataBuildingContext in constructor. - Move generator binding logic from SimpleValueBinder.bindSimpleValue to bindBasicValue. - Update GrailsPropertyBinder and tests to use renamed bindBasicValue method. - Update all relevant specs to match new constructor and method signatures.

- Move identifier property resolution and sequence detection logic from SimpleIdBinder to BasicValueIdCreator. - Simplify SimpleIdBinder.bindSimpleId by using the new encapsulated methods. - Update relevant unit tests to verify the refactored logic.

When firstExpressionIsRequiredBoolean() is true and operator is OR (e.g. findPublishedByTitleOrAuthor), the refactored getJunction() incorrectly placed the boolean criterion inside the Disjunction, producing: (boolean) OR expr1 OR expr2 Fixed to produce the correct: boolean AND (expr1 OR expr2) by wrapping in a top-level Conjunction with a nested Disjunction. Assisted-by: OpenCode <opencode@opencode.ai>

@ignore

Reverted Thread.currentThread().getContextClassLoader() back to getClass().getClassLoader() in DelegateAsyncTransformation. The context classloader does not have plugin module classes during Gradle AST compilation, causing AsyncTransactionalServiceSpec to fail. Also removed @ignore("FIX THIS LATER") from the spec. Assisted-by: OpenCode <opencode@opencode.ai>

@requires

Restores test coverage for hibernate5, mongodb, and core-test that was lost in the 8.0.x-hibernate7 merge. TCK specs: - FindByMethodSpec: restore 16 missing test methods from spring-boot-4 - OptimisticLockingSpec: add withNewSession-based tests for mongodb (matching spring-boot-4 pattern) alongside new withTransaction tests - PagedResultSpec: add core.gorm.suite to @requires - EnumSpec: restore findByEn()/findByEnInList() single-result tests without gates for core-test alongside new findAllBy versions Core-test specs: - Fix 6 specs disabled by @IgnoreIf(core.gorm.suite): update to addAllDomainClasses() for new GrailsDataTckManager API, restore missing imports, add targeted @requires only where simple datastore genuinely cannot handle the query - OneToOneWithProxiesSpec: remove unnecessary @requires gate All three suites verified green: core-test, hibernate5-core, mongodb-core Assisted-by: OpenCode <opencode@opencode.ai>

…bernate7

…date binding logic - Rename BasicValueIdCreator to BasicValueCreator. - Rename SimpleValueBinder.bindBasicValue to bindSimpleValue. - Update SimpleValueBinder to use BasicValueCreator internally for BasicValue creation. - Update all references, tests, and documentation to reflect the new class and method names.

@requires

Move multi-line @requires closure statements to new line after opening brace in FindByMethodSpec. Remove unused GrailsTransactionTemplate import from OptimisticLockingSpec. Assisted-by: OpenCode <opencode@opencode.ai>

…ernate7

…rage Add 15 new test methods (from 5 to 20 total) covering all ProxyHandler and ProxyFactory contract methods: isInitialized (null, non-proxied, persistent collection, Hibernate proxy, Groovy proxy), unwrap (Hibernate proxy, Groovy proxy, non-proxy), getIdentifier (Hibernate proxy, non-proxied, null), createProxy, and isProxy (non-Hibernate object). The Groovy proxy isInitialized test is excluded because it depends on a source fix to HibernateProxyHandler.isInitialized() that will be submitted in a separate PR. Assisted-by: OpenCode <opencode@opencode.ai>

The Hibernate 7 HibernateProxyHandler.isInitialized() was missing a check for Groovy proxies (ProxyInstanceMetaClass), causing uninitialized Groovy proxies to be incorrectly reported as initialized. This is because the fallback Hibernate.isInitialized() returns true for any non-Hibernate object. Add GroovyProxyInterceptorLogic.isInitialized() helper that checks ProxyInstanceMetaClass.isProxyInitiated(), and call it from HibernateProxyHandler.isInitialized() before the Hibernate fallback. The Hibernate 5 implementation already had this check. This restores parity and adds the corresponding test. Assisted-by: OpenCode <opencode@opencode.ai>

- Rename groovyProxyInit to groovyProxyInitialized for clearer state semantics - Add ProxyInstanceMetaClass precondition assertion in Groovy proxy test Assisted-by: OpenCode <opencode@opencode.ai>

jdaugherty · 2026-04-17T15:43:28Z

FYI: I added this comment due to the micronaut mismatches. I'll add a work around for this for now (no javadoc so it's probably ok to force api compatibility). Hopefully they update on the micronaut side so there aren't any issues.

jdaugherty · 2026-04-17T16:07:21Z

Running this locally, I only had 1 test failure:

Which was due to OOM.

jdaugherty · 2026-04-17T16:07:44Z

@borinquenkid can you take a look at that failure?

borinquenkid · 2026-04-17T16:47:55Z

@jdaugherty I created a local task not checked in and needed this setup to run relaibli sub.tasks.withType(Test).configureEach { t -> │
│ t.maxParallelForks = 1 │
│ t.maxHeapSize = "3g" │
│ t.jvmArgs("-XX:MaxMetaspaceSize=512m") │
│ t.forkEvery = 1 │
│ }

…TenancyBidirectionalManyToManySpec, and disable dependency verification for external Groovy build

…va version mismatch in GSP compilation

jdaugherty · 2026-04-19T00:40:28Z

Still TODO:

I need to understand why micronaut was choosing the wrong version of test containers (reason we put it in the bom)
need to take another pass at the out of tree updates
need to review hibernate / final PR state (may recreate in that case)

…e scalability analysis

jdaugherty · 2026-04-21T12:56:52Z

@borinquenkid the latest round seems to have broken a lot of tests. Can you please take a look? I'd like to do another pass at this PR when you're done so we can actually review this functionality.

borinquenkid · 2026-04-21T16:16:01Z

I reset hard some of the changes because they touched core which affects other modules.
Here is an assessment of the limitations:

GORM Scalability Analysis & Multi-Tenancy Risk Profile

Metric	Safe Operating Range	High Risk Range	Critical Failure
Total Domain Classes	< 150	150 - 300	> 500
Total Tenants	< 200	200 - 500	> 1,000
Total API Objects	< 30,000	30k - 50,000	> 100,000

Summary for June Release

Suitability: Current code is stable for small-to-medium applications but NOT supported for Dynamic Schema SaaS due to the lack of tenant eviction/lifecycle management.
Mandatory Requirement: To achieve production-grade stability for June, the architecture must transition to a Class-Singleton Orchestrator where API instances are shared across all tenants.
Safety Ceiling: The 50,000 API object ceiling must be re-implemented as a mandatory safety gate until the orchestrator transition is complete.

jdaugherty · 2026-04-22T14:58:31Z

TODO:

reduce memory back down
fix rat issues
@jdaugherty to take 1 last pass before review
do the review on hibernate 7

…ernate7

testlens-app · 2026-04-22T16:31:38Z

✅ All tests passed ✅

🏷️ Commit: 6e09712
▶️ Tests: 17370 executed
⚪️ Checks: 34/34 completed

Learn more about TestLens at testlens.app.

jdaugherty · 2026-04-26T14:43:11Z

My bom changes are really separate from this review. They fix a critical mistake in 7.0.x - you have to still override the hibernate 5 version instead of just using the bom. I'm going to look at pulling those changes out of this review so that the review is focused on hibernate alone.

jdaugherty · 2026-04-27T23:40:52Z

This PR is currently blocked by #15605

Once that PR is merged, we will merge it up and then into this PR

borinquenkid and others added 30 commits March 29, 2026 18:27

hibernate 7: linting and expanding tests

cd2c8d1

chore: fix CodeNarc violations in grails-datamapping-tck and improve …

5d11c06

…style aggregator

chore: fix final CodeNarc indentation violation in grails-datamapping…

4aea0cb

…-tck

chore: fix Apache Rat audit failures

980cbe9

fix: various build and test failures in Hibernate 7 and GSP modules

b8b16f8

datamapping-core complilation

8d9b371

codenarc

240b972

Merge branch '8.0.x' into 8.0.x-hibernate7

f3e0f35

linting

ac62344

Merge remote-tracking branch 'jamesfredley/spring-boot-4' into 8.0.x-…

e36e38a

…hibernate7

testing violations plugins

713487d

hibernate7 codeNarc fixes

e8ee4ba

refactor: change SimpleValueBinder constructor visibility to private

e649743

Merge branch 'spring-boot-4' into 8.0.x-hibernate7

e90fb81

Merge branch 'fix/restore-non-hibernate7-test-coverage' into 8.0.x-hi…

cb25275

…bernate7

style: fix CodeNarc violations in TCK specs

c8944ed

Move multi-line @requires closure statements to new line after opening brace in FindByMethodSpec. Remove unused GrailsTransactionTemplate import from OptimisticLockingSpec. Assisted-by: OpenCode <opencode@opencode.ai>

refactor: rename of HibernateProperty hierarchy

ecf8caf

Merge remote-tracking branch 'origin/8.0.x-hibernate7' into 8.0.x-hib…

6fd8c13

…ernate7

Merge branch '8.0.x-hibernate7' into 8.0.x-hibernate7-dev

1a66edc

refactor: address Copilot review feedback on PR #15548

148d718

- Rename groovyProxyInit to groovyProxyInitialized for clearer state semantics - Add ProxyInstanceMetaClass precondition assertion in Groovy proxy test Assisted-by: OpenCode <opencode@opencode.ai>

jdaugherty added 2 commits April 17, 2026 10:24

Merge branch '8.0.x' into 8.0.x-hibernate7

2b6cd05

Restore formatting & fix bad merges

f57b692

jdaugherty force-pushed the 8.0.x-hibernate7 branch from 04c43e8 to f57b692 Compare April 17, 2026 14:35

jdaugherty added 2 commits April 17, 2026 10:36

Revert non-lazy expansion

1f9b485

Revert bad merge

01017ff

Add workaround for javaparser mismatch & micronaut not updating

a1cd4df

borinquenkid added 8 commits April 17, 2026 12:16

fixed OOM

61818f0

fix build failures: increase CI test memory, fix compilation in Multi…

629e94a

…TenancyBidirectionalManyToManySpec, and disable dependency verification for external Groovy build

update Hibernate 7 documentation

6b29d8b

Upgrade Testcontainers to 2.0.4 and use new artifact naming convention

d53fe20

fix spec

af9e533

Force targetCompatibility for all AbstractCompile tasks to prevent Ja…

da8ba1a

…va version mismatch in GSP compilation

analysis of OOM

3a0fe5f

H7: Reduced instances of GrailHibernateTemplates

751a7d8

H7: Refactor InstanceApiHelper to a per-datastore singleton and updat…

848c778

…e scalability analysis

borinquenkid force-pushed the 8.0.x-hibernate7 branch from 1d767f9 to 848c778 Compare April 21, 2026 16:05

borinquenkid and others added 2 commits April 21, 2026 11:42

update RAT

b9bc3a9

Remove micronaut workaround

5246ee1

Merge remote-tracking branch 'origin/8.0.x-hibernate7' into 8.0.x-hib…

6e09712

…ernate7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hibernate 7#15568

Hibernate 7#15568
jdaugherty wants to merge 1143 commits into8.0.xfrom
8.0.x-hibernate7

jdaugherty commented Apr 10, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

borinquenkid commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 19, 2026

Uh oh!

jdaugherty commented Apr 21, 2026

Uh oh!

borinquenkid commented Apr 21, 2026

Uh oh!

jdaugherty commented Apr 22, 2026

Uh oh!

testlens-app Bot commented Apr 22, 2026

Uh oh!

jdaugherty commented Apr 26, 2026

Uh oh!

jdaugherty commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jdaugherty commented Apr 10, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 17, 2026

Uh oh!

borinquenkid commented Apr 17, 2026

Uh oh!

jdaugherty commented Apr 19, 2026

Uh oh!

jdaugherty commented Apr 21, 2026

Uh oh!

borinquenkid commented Apr 21, 2026

GORM Scalability Analysis & Multi-Tenancy Risk Profile

Summary for June Release

Uh oh!

jdaugherty commented Apr 22, 2026

Uh oh!

testlens-app Bot commented Apr 22, 2026

✅ All tests passed ✅

Uh oh!

jdaugherty commented Apr 26, 2026

Uh oh!

jdaugherty commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants