Where Query documentation improvements#15599
Conversation
|
This question isn’t related to the pull request. I can only help with questions about the PR’s code or comments. |
|
@gsartori is this ready to review again? |
Nope, ill complete it tomorrow in consideration of your review, ill comment here once done |
|
@jdaugherty I've reintroduced the paragraph about the auto-generated aliases. The PR can be reviewd 👍 |
jamesfredley
left a comment
There was a problem hiding this comment.
Reviewed the documentation changes against the codebase. The technical claims are accurate (delete() failOnError omission, Map-based multi-field sort, nested criteria block, properties = [...] binding, list() pagination params - all verified against DetachedCriteria.groovy, DynamicFinder.java, GormInstanceApi.groovy, DetachedCriteriaTransformer.java, and WebDataBinding). Leaving line-level suggestions for editorial / consistency / flow polish. The Map-sort feature was previously undocumented, so this PR genuinely fills a gap.
Non-blocking but worth noting:
- The PR body is empty -
CONTRIBUTING.mdexpects a description and (where applicable) issue references. - Branch
7.0.x->7.0.xskips thedocs/prefix convention fromAGENTS.md, so auto-labelers won't tag this asdocumentation. - The newly-documented Map-sort path (
DynamicFinder.applySortForMap) has no test coverage inDetachedCriteriaSpec. PerAGENTS.mdrule #10 ("every code change must include new or enhanced tests"), consider adding a small spec to lock in the contract being documented. grails-data-graphql/.../DeleteEntityDataFetcher.groovyincorrectly passesfailOnError: truetodelete()- that parameter is silently ignored. Worth filing separately.
No description provided.