Skip to content

[#10519] fix(postgresql): handle unconstrained NUMERIC type with precision=0 #10534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuqi1129 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[#10519] fix(postgresql): handle unconstrained NUMERIC type with precision=0 #10534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .../main/java/org/apache/gravitino/catalog/postgresql/converter/PostgreSqlTypeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,23 @@ public Type toGravitino(JdbcTypeBean typeBean) {
.map(Types.TimestampType::withTimeZone)
.orElseGet(Types.TimestampType::withTimeZone);
case NUMERIC:
return Types.DecimalType.of(typeBean.getColumnSize(), typeBean.getScale());
Integer columnSize = typeBean.getColumnSize();
Integer scale = typeBean.getScale();
// Unconstrained NUMERIC (no precision/scale) — PostgreSQL JDBC returns columnSize=0.
// Use ExternalType to preserve arbitrary-precision semantics (backed by BigDecimal).
if (columnSize == null || columnSize == 0) {
return Types.ExternalType.of(NUMERIC);
}
int effectiveScale = scale != null ? scale : 0;
// NUMERIC(P, 0) with small P can be represented as integer types for better performance.
if (effectiveScale == 0) {
if (columnSize < 10) {
return Types.IntegerType.get();
} else if (columnSize < 19) {
return Types.LongType.get();
}
}
return Types.DecimalType.of(columnSize, effectiveScale);
case VARCHAR:
return typeBean.getColumnSize() == null
? Types.StringType.get()
Expand Down
8 changes: 8 additions & 0 deletions ...t/java/org/apache/gravitino/catalog/postgresql/converter/TestPostgreSqlTypeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,14 @@ public void testToGravitinoType() {
checkJdbcTypeToGravitinoType(Types.TimestampType.withoutTimeZone(3), TIMESTAMP, 23, null, 3);
checkJdbcTypeToGravitinoType(Types.TimestampType.withoutTimeZone(6), TIMESTAMP, 26, null, 6);
checkJdbcTypeToGravitinoType(Types.DecimalType.of(10, 2), NUMERIC, 10, 2, 0);
// Unconstrained NUMERIC (no precision) returns columnSize=0 from JDBC metadata;
// mapped to ExternalType to preserve arbitrary-precision semantics (BigDecimal).
checkJdbcTypeToGravitinoType(Types.ExternalType.of(NUMERIC), NUMERIC, 0, 0, 0);
checkJdbcTypeToGravitinoType(Types.ExternalType.of(NUMERIC), NUMERIC, null, null, 0);
// NUMERIC(P, 0) with small P is mapped to integer types for better performance.
checkJdbcTypeToGravitinoType(Types.IntegerType.get(), NUMERIC, 9, 0, 0);
checkJdbcTypeToGravitinoType(Types.LongType.get(), NUMERIC, 18, 0, 0);
checkJdbcTypeToGravitinoType(Types.DecimalType.of(20, 0), NUMERIC, 20, 0, 0);
checkJdbcTypeToGravitinoType(Types.VarCharType.of(20), VARCHAR, 20, null, 0);
checkJdbcTypeToGravitinoType(Types.FixedCharType.of(20), BPCHAR, 20, null, 0);
checkJdbcTypeToGravitinoType(Types.StringType.get(), TEXT, null, null, 0);
Expand Down
Loading