[Improvement] Complete v2 audit operation mapping coverage#10553
Open
FANNG1 wants to merge 1 commit intoapache:mainfrom
Open
[Improvement] Complete v2 audit operation mapping coverage#10553FANNG1 wants to merge 1 commit intoapache:mainfrom
FANNG1 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
OperationTypevalues inCompatibilityUtilsAuditLog.Operationwith the concrete audit operation values needed by v2OperationTypevalues map to a non-unknown audit operationWhy
The previous v2 compatibility mapping only covered part of the listener operation space.
Many supported operations still fell back to
UNKNOWN_OPERATION, which made audit output incomplete and inconsistent.This change makes v2 audit mapping complete for all known operation types and keeps
UNKNOWN_OPERATIONreserved for truly unknown inputs only.How it was tested
Risks / follow-ups
AuditLog.Operationis still shared with legacy audit code, so this change expands the enum surface beyond the legacy formatter coverage.OperationTypevalues are added later, the new guard test should fail until the mapping is updated.