Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/actions/setup-java-toolchains/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: 'Setup Java Toolchains'
description: 'Install a primary JDK and JDK 24 (for Trino), register JDK 24 with Gradle toolchain'

inputs:
java-version:
description: 'Primary Java version'
default: '17'
cache:
description: 'Gradle cache setting'
default: 'gradle'

runs:
using: composite
steps:
- uses: actions/setup-java@v4
id: setup-jdk24
with:
java-version: 24
distribution: temurin

- uses: actions/setup-java@v4
with:
java-version: ${{ inputs.java-version }}
distribution: temurin
cache: ${{ inputs.cache }}

- name: Register JDK 24 with Gradle toolchain
shell: bash
run: |
mkdir -p ~/.gradle
GRADLE_PROPERTIES=~/.gradle/gradle.properties
TMP=$(mktemp)
if [ -f "${GRADLE_PROPERTIES}" ]; then
awk '!/^org\.gradle\.java\.installations\.paths=/' "${GRADLE_PROPERTIES}" > "${TMP}"
fi
echo "org.gradle.java.installations.paths=${{ steps.setup-jdk24.outputs.path }}" >> "${TMP}"
mv "${TMP}" "${GRADLE_PROPERTIES}"
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,9 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
- uses: ./.github/actions/setup-java-toolchains
with:
java-version: 17
distribution: 'temurin'
cache: 'gradle'

- name: Build with Gradle
run: |
Expand Down Expand Up @@ -164,11 +162,9 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
- uses: ./.github/actions/setup-java-toolchains
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'

- name: Test publish to local
run: ./gradlew publishToMavenLocal -PskipWeb=true -x test
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/cron-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,9 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
- uses: ./.github/actions/setup-java-toolchains
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'


- name: Set up QEMU
uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/frontend-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,9 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
- uses: ./.github/actions/setup-java-toolchains
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'

- name: Set up QEMU
uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gvfs-fuse-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ jobs:
- name: Integration test
run: |
./gradlew build -PskipWeb=true -x :clients:client-python:build -x test -x web
./gradlew compileDistribution -PskipWeb=true -x :clients:client-python:build -x test -x web
./gradlew build -PskipWeb=true -x :clients:client-python:build -x test -x web -PskipTrinoConnector=true
./gradlew compileDistribution -PskipWeb=true -x :clients:client-python:build -x test -x web -PskipTrinoConnector=true
cd clients/filesystem-fuse
make test-s3
make test-fuse-it
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/trino-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,9 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
- uses: ./.github/actions/setup-java-toolchains
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
cache: 'gradle'

- name: Set up QEMU
uses: docker/setup-qemu-action@ce360397dd3f832beb865e1373c09c0e9f86d70a # v4.0.0
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/trino-multi-version-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-java@v4
with:
java-version: 17
distribution: 'temurin'
cache: 'gradle'
- uses: ./.github/actions/setup-java-toolchains

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Expand Down
6 changes: 6 additions & 0 deletions docs/how-to-build.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ license: "This software is licensed under the Apache License version 2."
./gradlew build -PpythonVersion=3.12
```

If you don't need to build the Trino connector (for example, when building on a machine without JDK 24), you can skip it with:

```shell
./gradlew build -PskipTrinoConnector=true
```

If you want to build a module on its own, like the Spark connector, you can use Gradle to build a module with a specific name, like so:

```shell
Expand Down
26 changes: 16 additions & 10 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,22 @@ include("iceberg:iceberg-rest-server")
include("lance:lance-common")
include("lance:lance-rest-server")
include("authorizations:authorization-ranger", "authorizations:authorization-common", "authorizations:authorization-chain")
include(
"trino-connector:trino-connector",
"trino-connector:trino-connector-435-439",
"trino-connector:trino-connector-440-445",
"trino-connector:trino-connector-446-451",
"trino-connector:trino-connector-452-468",
"trino-connector:trino-connector-469-472",
"trino-connector:trino-connector-473-478",
"trino-connector:integration-test"
)
val skipTrinoConnector: Boolean =
gradle.startParameter.projectProperties["skipTrinoConnector"]?.toBoolean() ?: false
if (!skipTrinoConnector) {
Comment thread
diqiu50 marked this conversation as resolved.
include(
"trino-connector:trino-connector",
"trino-connector:trino-connector-435-439",
"trino-connector:trino-connector-440-445",
"trino-connector:trino-connector-446-451",
"trino-connector:trino-connector-452-468",
"trino-connector:trino-connector-469-472",
"trino-connector:trino-connector-473-478",
"trino-connector:integration-test"
)
} else {
println("Skipping trino-connector modules since skipTrinoConnector is set to true")
}
include("spark-connector:spark-common")
if (scalaVersion == "2.12") {
// flink only support scala 2.12
Expand Down
Loading