-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4024]Refactor: Reduce unnecessary queries in catalog JDBC implementation #6540
base: main
Are you sure you want to change the base?
Conversation
...org/apache/gravitino/storage/relational/mapper/provider/base/CatalogMetaBaseSQLProvider.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
08f5d42
to
5a624d2
Compare
5a624d2
to
72a9039
Compare
72a9039
to
581134d
Compare
@yuqi1129, is our test infrastructure broken? I also encountered failures while testing locally. I think they are caused by TestContainers. |
I tested the failing part in CI locally There is no failure by executing independently rather than in parallel. |
This should be a network problem; let me try again. |
f8a67e0
to
08cb925
Compare
@yuqi1129 I have fixed the error:https://github.com/apache/gravitino/actions/runs/13667966296/job/38212834258?pr=6540: run CI locally with: ./gradlew test -PskipTests -PtestMode=embedded -PjdkVersion=17 -PjdbcBackend=h2 PskipDockerTests=false -x :web:web:test -x :web:integration-test:test -x :clients:client-python:test It failed with another case: |
What changes were proposed in this pull request?
For queries involving more related tables, use a JOIN operation instead of executing separate queries to retrieve the results.
Why are the changes needed?
There are many unnecessary query operations, and the two tables can be directly associated to reduce these operations.
Part of: #4024
Does this PR introduce any user-facing change?
no
How was this patch tested?
unit tests & backend intergation tests