Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6563] improvement(core) Optimize the configuration iterator in FileSystem provider #6576

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

sunxiaojian
Copy link
Contributor

@sunxiaojian sunxiaojian commented Mar 3, 2025

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

Fix: #6563

Does this PR introduce any user-facing change?

NO

How was this patch tested?

TestFileSystemUtils#testCreateConfiguration

@tengqm
Copy link
Contributor

tengqm commented Mar 3, 2025

Good work!
lgtm

@sunxiaojian sunxiaojian force-pushed the optimize-configuration branch 4 times, most recently from 0857618 to 02c5f43 Compare March 4, 2025 07:21
@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 4, 2025

@sunxiaojian
There is something wrong with Trino-related tests currently.

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian There is something wrong with Trino-related tests currently.

ok , I'm resolving it.

@sunxiaojian sunxiaojian force-pushed the optimize-configuration branch from 02c5f43 to 4d50a53 Compare March 5, 2025 09:14
@sunxiaojian
Copy link
Contributor Author

@yuqi1129 fixed , PTAL, thanks

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@jerryshao jerryshao merged commit 6451189 into apache:main Mar 6, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the configuration iterator in FileSystem provider
4 participants