[#6595] fix (trino-connector): Disable the Trino cascading query integration test #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this only skip cascading test, or it will skip all the Trino query tests? |
Only skip the Trino cascading query test. |
mchades
reviewed
Mar 4, 2025
| @@ -87,7 +87,6 @@ jobs: | |||
| run: | | |||
| ./gradlew -PskipTests -PtestMode=embedded -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false :trino-connector:integration-test:test | |||
| ./gradlew -PskipTests -PtestMode=deploy -PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false :trino-connector:integration-test:test | |||
| trino-connector/integration-test/trino-test-tools/run_test.sh | |||
There was a problem hiding this comment.
Should it be commented out instead of deleted directly?
There was a problem hiding this comment.
The trino-cascading-connector repository has now become private, so we need to reconsider where to place these tests.
There was a problem hiding this comment.
Before deciding where to put it, it's better to use comments instead of deleting directly.
mchades
approved these changes
Mar 5, 2025
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Mar 7, 2025
…y integration test (apache#6597) ### What changes were proposed in this pull request? Disable the Trino cascading query integration test ### Why are the changes needed? Fix: apache#6595 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable the Trino cascading query integration test
Why are the changes needed?
Fix: #6595
Does this PR introduce any user-facing change?
No
How was this patch tested?
No