[#6561] improvement(core): Cache Hadoop Filesystem instance on Gravitino server to improve the performance #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
|
@yuqi1129 PTAL, thanks |
|
I will take some time to verify whether this works in the loud filesystem as the related ITs are not triggered by default. |
yuqi1129
reviewed
Mar 8, 2025
| * @return The FileSystem instance. | ||
| * @throws IOException If the FileSystem instance cannot be created. | ||
| */ | ||
| default FileSystem getFileSystem( |
There was a problem hiding this comment.
Will this method only be used by the Gravitino server?
| @Nonnull Path path, @Nonnull Map<String, String> config, boolean disableCache) | ||
| throws IOException { | ||
| // disable cache | ||
| config.put(String.format("fs.%s.impl.disable.cache", scheme()), String.valueOf(disableCache)); |
There was a problem hiding this comment.
What if the config already contains key fs.%s.impl.disable.cache? will we cover it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cache Hadoop Filesystem instance on Gravitino server to improve the performance
Why are the changes needed?
Fix: #6561
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A