Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog #6639

Merged
merged 1 commit into from
Mar 9, 2025
Merged

[#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog #6639

merged 1 commit into from
Mar 9, 2025
+34 −1

Conversation

sunxiaojian
Copy link
Contributor

What changes were proposed in this pull request?

jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog

Why are the changes needed?

Fix: #6630

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

@sunxiaojian sunxiaojian changed the title [#6630] fixed(jdbc): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog [#6630] fixed(jdbc-catalog): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog Mar 7, 2025
@sunxiaojian sunxiaojian changed the title [#6630] fixed(jdbc-catalog): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog [#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog Mar 7, 2025
@sunxiaojian
Copy link
Contributor Author

@yuqi1129 PTAL, thanks

@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 8, 2025

@sunxiaojian
Have you confirmed that the change works and the configuration is effective? Is is possible to add some UTs ?

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian Have you confirmed that the change works and the configuration is effective? Is is possible to add some UTs ?

@yuqi1129 UTs have been added

@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 8, 2025

LGTM

@yuqi1129 yuqi1129 added the branch-0.8 Automatically cherry-pick commit to branch-0.8 label Mar 9, 2025
yuqi1129
yuqi1129 approved these changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @sunxiaojian , thanks for your contribution.

@yuqi1129 yuqi1129 merged commit 0c9f581 into apache:main Mar 9, 2025
28 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 9, 2025
@sunxiaojian @web-flow
[#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work whe…
cdeef9d 
…n connecting to JDBC catalog (#6639)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog

### Why are the changes needed?

Fix: #6630

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi1129 yuqi1129 yuqi1129 approved these changes

Assignees

@sunxiaojian sunxiaojian

Labels
branch-0.8 Automatically cherry-pick commit to branch-0.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug report] jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog
2 participants
@sunxiaojian @yuqi1129