[#6947] subtask(web): Web UI supports fileset multiple locations #7033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mchades Can you help to review the pr? |
Contributor
|
I think we should also update the display page to support multiple locations, what do you think? @mchades |
Contributor
Agreed. |
Contributor
The switch seems to symbolize the default location, but at first glance it still appears confusing. Can we achieve this by removing the switch and adding a "default-location-name" property in the fileset property? The value of the property should be in the form of a dropdown list, with the values in the dropdown list being enumerated from the location names in locations. |
Contributor
Author
|
update details for storage locations
default location switch has tooltips, choose first item default, from an interaction point of view, it makes more sense for relevant attributes to be placed in their corresponding locations, and fileset property placed far away do not have proper guidance
|
Contributor
|
@mchades can you please help to verify this feature? |
Contributor
|
you need to handle the case: 
the schema is: the catalog is: |
Contributor
Author
|
mchades
approved these changes
Apr 28, 2025
Contributor
mchades
left a comment
mchades
left a comment
There was a problem hiding this comment.
LGTM. Do you want to review it? @jerryshao
Contributor
|
I'm fine if you think it is enough. |
unknowntpo
pushed a commit
to unknowntpo/gravitino
that referenced
this pull request
Apr 30, 2025
apache#7033) ### What changes were proposed in this pull request? Web UI supports fileset multiple locations <img width="647" alt="image" src="https://github.com/user-attachments/assets/bfb877fd-312c-4de0-835c-68c5258deefd" /> <img width="658" alt="image" src="https://github.com/user-attachments/assets/249ce1b8-ddca-4e6f-8188-9ec62a9f308c" /> ### Why are the changes needed? N/A Fix: apache#6947 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
May 7, 2025
apache#7033) ### What changes were proposed in this pull request? Web UI supports fileset multiple locations <img width="647" alt="image" src="https://github.com/user-attachments/assets/bfb877fd-312c-4de0-835c-68c5258deefd" /> <img width="658" alt="image" src="https://github.com/user-attachments/assets/249ce1b8-ddca-4e6f-8188-9ec62a9f308c" /> ### Why are the changes needed? N/A Fix: apache#6947 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
May 7, 2025
apache#7033) ### What changes were proposed in this pull request? Web UI supports fileset multiple locations <img width="647" alt="image" src="https://github.com/user-attachments/assets/bfb877fd-312c-4de0-835c-68c5258deefd" /> <img width="658" alt="image" src="https://github.com/user-attachments/assets/249ce1b8-ddca-4e6f-8188-9ec62a9f308c" /> ### Why are the changes needed? N/A Fix: apache#6947 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually
vishnu-chalil
pushed a commit
to vishnu-chalil/gravitino
that referenced
this pull request
Jul 14, 2025
apache#7033) ### What changes were proposed in this pull request? Web UI supports fileset multiple locations <img width="647" alt="image" src="https://github.com/user-attachments/assets/bfb877fd-312c-4de0-835c-68c5258deefd" /> <img width="658" alt="image" src="https://github.com/user-attachments/assets/249ce1b8-ddca-4e6f-8188-9ec62a9f308c" /> ### Why are the changes needed? N/A Fix: apache#6947 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Web UI supports fileset multiple locations
Why are the changes needed?
N/A
Fix: #6947
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually