Skip to content

[#5803] feat(docker-image): Change username in hive Dockerfile from datastrato to gravitino #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

unknowntpo
Copy link
Collaborator

@unknowntpo unknowntpo commented Apr 23, 2025

This PR changed username in hive, kerberos-hive Dockerfile from datastrato to gravitino, and added a commit 5d58e1d to verify the image is built correctly, this commit will be reverted after new version of image is published.

The steps below need to be done before merging this PR:

  • Update docker-image-details.md, add information about gravitino-ci:kerberos-hive-0.1.6 and gravitino-ci:hive-0.1.19 (new release)
  • Verify new image passed all Backend Integration Test / BackendIT-on-pr in CI.
  • Ask @xunliu to publish new docker image
  • Revert 5d58e1d (this commit is just for testing newly built image before publishing)
  • Change GRAVITINO_CI_HIVE_DOCKER_IMAGE, GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE in ./build.gradle.kts to newly published version

What changes were proposed in this pull request?

Rename datastrato to gravitino since we've donating this repo to ASF.

Fix: #5803

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Local test

First, execute these steps to build image:

# build hive image
./dev/docker/build-docker.sh --platform all --type hive --image <image name and tag> --tag hive-test --latest

# build kerberos image
./dev/docker/build-docker.sh --platform all --type kerberos-hive --image <image name and tag> --tag kerberos-hive-test --latest

Run tests in ProxyCatalogHiveIT, HiveUserAuthenticationIT to verify that image is built successfully.

GRAVITINO_CI_HIVE_DOCKER_IMAGE=unknowntpo/gravitino-hive-ci-test:hive-test
GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE=unknowntpo/gravitino-kerberos-hive-ci-test:kerberos-hive-test

./gradlew :catalogs:catalog-hive:test --tests "org.apache.gravitino.catalog.hive.integration.test.ProxyCatalogHiveIT" -PskipDockerTests=false

./gradlew :catalogs:catalog-hive:test --tests "org.apache.gravitino.catalog.hive.integration.test.HiveUserAuthenticationIT" -PskipDockerTests=false

CI test

I built the image

and make a commit 5d58e1d that use these images to run CI tests.

@unknowntpo unknowntpo force-pushed the refactor-change-user-datastrato-to-gravitino branch from ac5b809 to eee0789 Compare April 23, 2025 00:37
@unknowntpo
Copy link
Collaborator Author

@xunliu Would you like to review this PR ?

@unknowntpo unknowntpo marked this pull request as ready for review April 23, 2025 00:42
@jerryshao
Copy link
Contributor

Looks like you updated the dockerfile, you need to publish the new docker image, otherwise the CI will be failed.

@jerryshao
Copy link
Contributor

Maybe @xunliu can assist you to publish the new docker image.

@xunliu
Copy link
Member

xunliu commented Apr 23, 2025

hi @unknowntpo
Please build this Docker image on your local and temporarily modify docker image configure in the ITs, and let ITs passed.
OH, Please don't forget to update document: https://github.com/apache/gravitino/blob/main/docs/docker-image-details.md#apache-gravitino-ci-apache-hive-image, maybe need to add a new version introduction.
Thanks.

@xunliu xunliu requested review from xunliu, jerqi and mchades April 24, 2025 02:55
@unknowntpo unknowntpo changed the title feat: change username from datastrato to gravitino [#5803] feat(docker-image): Change username in hive, kerberos-hive Dockerfile from datastrato to gravitino Apr 24, 2025
@unknowntpo
Copy link
Collaborator Author

@xunliu description and PR title is updated.

@xunliu xunliu changed the title [#5803] feat(docker-image): Change username in hive, kerberos-hive Dockerfile from datastrato to gravitino [#5803] feat(docker-image): Change username in hive Dockerfile from datastrato to gravitino Apr 24, 2025
Comment on lines -175 to +176
param.environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "apache/gravitino-ci:hive-0.1.18")
param.environment("GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE", "apache/gravitino-ci:kerberos-hive-0.1.5")
param.environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "unknowntpo/gravitino-hive-ci-test:hive-test")
param.environment("GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE", "unknowntpo/gravitino-kerberos-hive-ci-test:kerberos-hive-test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unknowntpo Waiting Github Action passed, Please don't forget modify this env values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've added a TODO list in description as reminder.

@xunliu
Copy link
Member

xunliu commented Apr 25, 2025

@unknowntpo Please help remove datastrato/apache-ranger/.../ranger-admin.tar.gz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Unified user in the Hive Docker and ITs
3 participants