-
Notifications
You must be signed in to change notification settings - Fork 442
[#5803] feat(docker-image): Change username in hive
Dockerfile from datastrato to gravitino
#7040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[#5803] feat(docker-image): Change username in hive
Dockerfile from datastrato to gravitino
#7040
Conversation
ac5b809
to
eee0789
Compare
@xunliu Would you like to review this PR ? |
Looks like you updated the dockerfile, you need to publish the new docker image, otherwise the CI will be failed. |
Maybe @xunliu can assist you to publish the new docker image. |
hi @unknowntpo |
hive
, kerberos-hive
Dockerfile from datastrato to gravitino
@xunliu description and PR title is updated. |
hive
, kerberos-hive
Dockerfile from datastrato to gravitinohive
Dockerfile from datastrato to gravitino
param.environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "apache/gravitino-ci:hive-0.1.18") | ||
param.environment("GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE", "apache/gravitino-ci:kerberos-hive-0.1.5") | ||
param.environment("GRAVITINO_CI_HIVE_DOCKER_IMAGE", "unknowntpo/gravitino-hive-ci-test:hive-test") | ||
param.environment("GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE", "unknowntpo/gravitino-kerberos-hive-ci-test:kerberos-hive-test") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unknowntpo Waiting Github Action passed, Please don't forget modify this env values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I've added a TODO list in description as reminder.
@unknowntpo Please help remove |
… GitHub private access token
This PR changed username in
hive
,kerberos-hive
Dockerfile fromdatastrato
togravitino
, and added a commit 5d58e1d to verify the image is built correctly, this commit will be reverted after new version of image is published.The steps below need to be done before merging this PR:
docker-image-details.md
, add information aboutgravitino-ci:kerberos-hive-0.1.6
andgravitino-ci:hive-0.1.19
(new release)GRAVITINO_CI_HIVE_DOCKER_IMAGE
,GRAVITINO_CI_KERBEROS_HIVE_DOCKER_IMAGE
in./build.gradle.kts
to newly published versionWhat changes were proposed in this pull request?
Rename datastrato to gravitino since we've donating this repo to ASF.
Fix: #5803
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test
First, execute these steps to build image:
Run tests in
ProxyCatalogHiveIT
,HiveUserAuthenticationIT
to verify that image is built successfully.CI test
I built the image
and make a commit 5d58e1d that use these images to run CI tests.