Skip to content

[#5202] feat(client-python): Support Gravitino Type Serdes - deserializer #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tsungchih
Copy link
Contributor

What changes were proposed in this pull request?

This is the second part (totally 4 planned) of implementation to the following classes from Java to support Column and its default value, including:

  • JsonUtils: readDataType() and its related methods to deserialize various Gravitino Types.
  • TypeDeserializer

The TypeDeserializer will be used in the incoming ColumnDTO implementation to deserialize data_type field.

Why are the changes needed?

We need to support Column and its default value in python client.

#5202

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit tests.

@tsungchih
Copy link
Contributor Author

@xunliu @unknowntpo @jerryshao Could you please help with reviewing this PR when you are available? I would greatly appreciate any feedback from you. Thanks.

@jerryshao
Copy link
Contributor

@mchades would you please also take a review?

@jerryshao
Copy link
Contributor

LGTM. @unknowntpo would you please also take a review again?

@unknowntpo
Copy link
Collaborator

@jerryshao @tsungchih LGTM.

tsungchih added 15 commits May 30, 2025 22:09
with read_data_type and from_primitive_type_string

apache#5202

Signed-off-by: George T. C. Lai <[email protected]>
due to incorrect implementation

apache#5202

Signed-off-by: George T. C. Lai <[email protected]>
@unknowntpo unknowntpo force-pushed the feat-client-python-5202-part2-type-deserializer branch from 8d7e238 to a47a262 Compare May 30, 2025 14:09
@unknowntpo
Copy link
Collaborator

@jerryshao Would you like to merge this PR ?

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thx for your contributions!

@mchades mchades merged commit 671ae2d into apache:main Jun 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants