-
Notifications
You must be signed in to change notification settings - Fork 481
[#5202] feat(client-python): Support Gravitino Type Serdes - deserializer #7241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5202] feat(client-python): Support Gravitino Type Serdes - deserializer #7241
Conversation
@xunliu @unknowntpo @jerryshao Could you please help with reviewing this PR when you are available? I would greatly appreciate any feedback from you. Thanks. |
clients/client-python/gravitino/api/types/json_serdes/_helper/serdes_utils.py
Outdated
Show resolved
Hide resolved
@mchades would you please also take a review? |
LGTM. @unknowntpo would you please also take a review again? |
@jerryshao @tsungchih LGTM. |
with read_data_type and from_primitive_type_string apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
due to incorrect implementation apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
8d7e238
to
a47a262
Compare
@jerryshao Would you like to merge this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thx for your contributions!
What changes were proposed in this pull request?
This is the second part (totally 4 planned) of implementation to the following classes from Java to support Column and its default value, including:
readDataType()
and its related methods to deserialize various Gravitino Types.The
TypeDeserializer
will be used in the incomingColumnDTO
implementation to deserializedata_type
field.Why are the changes needed?
We need to support Column and its default value in python client.
#5202
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.