[#5202] feat(client-python): Support Gravitino Type Serdes - deserializer #7241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xunliu @unknowntpo @jerryshao Could you please help with reviewing this PR when you are available? I would greatly appreciate any feedback from you. Thanks. |
3 tasks
unknowntpo
reviewed
May 28, 2025
clients/client-python/gravitino/api/types/json_serdes/_helper/serdes_utils.py
Outdated
Show resolved
Hide resolved
|
@mchades would you please also take a review? |
|
LGTM. @unknowntpo would you please also take a review again? |
|
@jerryshao @tsungchih LGTM. |
with read_data_type and from_primitive_type_string apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
due to incorrect implementation apache#5202 Signed-off-by: George T. C. Lai <[email protected]>
unknowntpo
force-pushed
the
feat-client-python-5202-part2-type-deserializer
branch
from
8d7e238 to
a47a262
Compare
|
@jerryshao Would you like to merge this PR ? |
mchades
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the second part (totally 4 planned) of implementation to the following classes from Java to support Column and its default value, including:
readDataType()and its related methods to deserialize various Gravitino Types.The
TypeDeserializerwill be used in the incomingColumnDTOimplementation to deserializedata_typefield.Why are the changes needed?
We need to support Column and its default value in python client.
#5202
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.