Skip to content

GROOVY-11582: remove excess manifest attributes #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

eric-milles
Copy link
Member

@eric-milles eric-milles commented Feb 25, 2025

I suspect not all of these are still required. This is a draft to explore removing all or some. And for any kept, adding some docs and tests.

  • Ant-Version
  • Bundle-ClassPath
  • Created-By
  • DynamicImport-Package
  • Eclipse-BuddyPolicy
  • Eclipse-ExtensibleAPI
  • Extension-Name
  • Tool

@eric-milles
Copy link
Member Author

eric-milles commented Feb 25, 2025

This is also a work-in-progress for dropping Ant-Version and Created-By from the jarjar output, which retains those attributes due to use of the Ant jar task to repackage the jarjar archive.

@eric-milles eric-milles changed the title remove excess manifest attributes GROOVY-11571: remove excess manifest attributes Feb 25, 2025
@paulk-asert
Copy link
Contributor

This is also a work-in-progress for dropping Ant-Version and Created-By from the jarjar output, which retains those attributes due to use of the Ant jar task to repackage the jarjar archive.

Saw this after my previous comment. Yes, if we can really remove Created-By and Ant-Version, that would be great and remove the need for the hard-coded value for Created-By.

@eric-milles eric-milles changed the title GROOVY-11571: remove excess manifest attributes remove excess manifest attributes Mar 16, 2025
@paulk-asert
Copy link
Contributor

I merged in the "pre-work" and minor refactoring. Do you want to rebase this against master? Should reduce to just a few lines.

@paulk-asert paulk-asert marked this pull request as ready for review March 20, 2025 13:01
@eric-milles
Copy link
Member Author

I have rebased, added comments to the Eclipse-ExtensibleAPI line, and moved DynamicImport-Package and Eclipse-BuddyPolicy to main jar only. I should be able to dig up a jira ticket number for those two from the comments you left on GROOVY-11582.

I still think all 3 can go, but the urgency is not that great.

Just a note, I tried Main-Class in the org.apache.groovy-main plugin, but it did not end up at the end of the manifest, where I wanted it to be. That is why I added a project name check to GroovyLibraryExtension.

@apache apache deleted a comment from codecov-commenter Mar 20, 2025
@apache apache deleted a comment from codecov-commenter Mar 20, 2025
@apache apache deleted a comment from codecov-commenter Mar 24, 2025
@eric-milles eric-milles changed the title remove excess manifest attributes GROOVY-11582: remove excess manifest attributes Apr 28, 2025
@eric-milles eric-milles merged commit 50500bc into master Jul 15, 2025
38 checks passed
@eric-milles eric-milles deleted the GROOVY-11571 branch July 15, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants