-
Notifications
You must be signed in to change notification settings - Fork 807
GUACAMOLE-2139: Bump version numbers to 1.6.1. #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c546ca9 to
8a34adf
Compare
8a34adf to
563bd9c
Compare
…rty (supported since Maven 3.5.0).
…nstream use. This also removes the need to publish the parent POM as part of the release for guacamole-common and guacamole-ext.
|
I've modified things a bit further to remove all the repeated references to the parent POM version, as Maven supports using a The continued references to the guacamole-client version are now strictly in the main parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm good with the changes - the only thing that I wonder if it would be somehow possible to do is something to distinguish between when this new GuacamoleVersion class actually provides a version (the overall Guacamole Client instance) and when the class requires or implements a version (extensions). I'm thinking that there could be situations for folks writing extensions to accidentally reverse the logic in checking the provided vs. required version, and get unexpected results.
I'm not sure it's worth holding up these changes to do that - just a suggestion for something in the future - maybe make GuacamoleVersion into an abstract class and then have a couple of different implementations - RunningGuacamoleVersion and ImplementedGuacamoleVersion or something like that?
Let me know what you think - if you want to go ahead and merge these changes as-is, I'm good with that.
|
I think I prefer things as they are, mainly because I like conceptualizing the extension versioning as a set of requirements that the running Guacamole version must satisfy ("I need at least version X to be usable"), in which case the idea behind the |
This change bumps the version numbers of all guacamole-client projects to 1.6.1. In an attempt to reduce maintenance burden, this change also:
${project.version}, including the variousguac-manifest.jsonfiles.Going forward, this will allow us to just update the guacamole-client version with a single command like: