HDDS-2206. Separate handling for OMException and IOException in the Ozone Manager. Contributed by Supratim Deka

[supratimdeka]

https://issues.apache.org/jira/browse/HDDS-2206

Introduced a boolean config parameter to control exception propagation from OM to Clients.
If set to true, all system exceptions (IOException) are thrown as ServiceException to RPC client - this also propagates the complete server-side stack trace to the client. If false, system exception stack trace is logged locally on the server, not sent to client.
The default value is set to true for now. For Ozone GA, we can revisit this choice.

Business Exception (OMException) handling is not changed.

This change does not include propagation of exceptions from within Ratis server.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
-1	mvninstall	39	hadoop-hdds in trunk failed.
-1	mvninstall	38	hadoop-ozone in trunk failed.
-1	compile	22	hadoop-hdds in trunk failed.
-1	compile	16	hadoop-ozone in trunk failed.
+1	checkstyle	61	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	928	branch has no errors when building and testing our client artifacts.
-1	javadoc	23	hadoop-hdds in trunk failed.
-1	javadoc	20	hadoop-ozone in trunk failed.
0	spotbugs	1042	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	46	hadoop-hdds in trunk failed.
-1	findbugs	21	hadoop-ozone in trunk failed.
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
-1	mvninstall	34	hadoop-hdds in the patch failed.
-1	mvninstall	36	hadoop-ozone in the patch failed.
-1	compile	25	hadoop-hdds in the patch failed.
-1	compile	18	hadoop-ozone in the patch failed.
-1	javac	25	hadoop-hdds in the patch failed.
-1	javac	18	hadoop-ozone in the patch failed.
+1	checkstyle	56	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	1	The patch has no ill-formed XML file.
+1	shadedclient	712	patch has no errors when building and testing our client artifacts.
-1	javadoc	23	hadoop-hdds in the patch failed.
-1	javadoc	20	hadoop-ozone in the patch failed.
-1	findbugs	32	hadoop-hdds in the patch failed.
-1	findbugs	21	hadoop-ozone in the patch failed.
		_ Other Tests _
-1	unit	29	hadoop-hdds in the patch failed.
-1	unit	26	hadoop-ozone in the patch failed.
+1	asflicense	35	The patch does not generate ASF License warnings.
		2551

Subsystem	Report/Notes
Docker	Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/Dockerfile
GITHUB PR	#1637
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle
uname	Linux e85b794dee86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / a031388
Default Java	1.8.0_222
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/branch-findbugs-hadoop-ozone.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-compile-hadoop-hdds.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-compile-hadoop-ozone.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-javadoc-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-javadoc-hadoop-ozone.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-findbugs-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-findbugs-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/testReport/
Max. process+thread count	412 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone/common hadoop-ozone/ozone-manager U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1637/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[adoroszlai]

/label ozone

[arp7]

One thing I missed - where is the serialization of the exception message done over the wire?

[elek]

Thank you very much to open this pull request.

During the weekend the Ozone source code has been moved out from apache/hadoop repository to apache/hadoop-ozone repository.

This git commits are rewritten, but the branch of this pull request is also transformed (state of Saturday morning), you can use the new, migrated branch to recreate this pull request.

Your pull request is important for us: Can you please re-create your pull request in the new repository?

1. Create a new fork of https://github.com/apache/hadoop-ozone

2. Clone it and have both your fork and the apache repo as remotes:

git clone [email protected]:supratimdeka/hadoop-ozone.git
cd hadoop-ozone
git remote add apache [email protected]:apache/hadoop-ozone.git
git fetch apache

3. Fetch your migrated branch and push it to your fork.

git checkout -b HDDS-2206 apache/HDDS-2206
git push origin HDDS-2206

4. And create the new pull request on the new repository.

https://github.com/apache/hadoop-ozone/compare/master...supratimdeka:HDDS-2206?expand=1

If you need more information, please check this wiki page or contact with me (my github user name + apache.org).

Thank you, and sorry for the inconvenience.